Skip to content

update format checker #7281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 27, 2025
Merged

update format checker #7281

merged 6 commits into from
Jun 27, 2025

Conversation

christian-rauch
Copy link
Contributor

@christian-rauch christian-rauch commented Jun 17, 2025

Update the style checker script with newer clang-format version and make it executable.

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results
      (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

Copy link

update-docs bot commented Jun 17, 2025

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@christian-rauch christian-rauch force-pushed the format branch 2 times, most recently from 8ec7572 to 55df0f3 Compare June 17, 2025 22:25
@christian-rauch christian-rauch marked this pull request as ready for review June 17, 2025 22:38
@ssheorey
Copy link
Member

Hi @christian-rauch thanks for this update. Looks good.
Can you update yapf and nbformat as well (to the latest versions).

@christian-rauch
Copy link
Contributor Author

Can you update yapf and nbformat as well (to the latest versions).

Done.

@ssheorey
Copy link
Member

Thanks! Will merge this after some time, since this may cause style issues with some other PRs in progress.

@ssheorey ssheorey merged commit 5c1e9cc into isl-org:main Jun 27, 2025
21 of 32 checks passed
@christian-rauch christian-rauch deleted the format branch June 28, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants