Optionally include CUDA DLLs in open3d-package#7306
Closed
fegorsch wants to merge 1 commit intoisl-org:mainfrom
Closed
Optionally include CUDA DLLs in open3d-package#7306fegorsch wants to merge 1 commit intoisl-org:mainfrom
fegorsch wants to merge 1 commit intoisl-org:mainfrom
Conversation
In order to have a self-contained Python package with GPU-support on Windows, allow bundling the CUDA DLLs with open3d. This is useful when deploying open3d to systems where you cannot assume having CUDA toolkit installed.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type
Motivation and Context
In order to have a self-contained Python package with GPU-support on Windows, allow bundling the CUDA DLLs with open3d. This is especially useful when deploying open3d to non-developer machines where you cannot assume that CUDA is installed. It also is a step towards an official Python package with CUDA-support for Windows, which would save the effort of building yourself.
Checklist:
python util/check_style.py --applyto apply Open3D code styleto my code.
updated accordingly.
results (e.g. screenshots or numbers) here.
Description
Added CMake variable
BUNDLE_CUDA_SHARED_LIBS, which causes all DLLs from the build system's CUDA-installation to be included in the wheel. Only works on Windows and only ifBUILD_CUDA_MODULEis on.