-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/store #125
Feature/store #125
Conversation
Very slick! Took a quick look at the branch... are you going to use the sidebar for all the products or just ones you want to highlight? |
I was thinking just sidebar for now - when we get more products, can do a page for each one? I suppose it's a little lazy to use the feed here to show the films for sale. The whole page should be a grid of products --- once the functionality is there, we should revisit |
fb491c9
to
77a3130
Compare
77a3130
to
bdcc141
Compare
bdcc141
to
564c599
Compare
rebase |
taking dollar billzzzz now... last step = create shipping order. |
Current flow is working in (island + stripe + shipwire) sandbox:
TODO:
|
Completed:
TODO:
|
yeah dude! Let me know if you want me to look it over On Thu, Sep 3, 2015 at 10:11 PM Sander Pick [email protected]
|
definitely do! will spend monday trying to get this 100% ready for On Thu, Sep 3, 2015 at 10:55 PM, Eyal Cohen [email protected]
|
def gonna want some unit test for this shit. TODO:
On Fri, Sep 4, 2015 at 8:35 AM, Sander Pick [email protected] wrote:
|
The "processing step" loads a random GIF tagged with "processing" (the animating framework) from the Giphy API haha... kinda goofy but I like it. TODO:
|
^^ option to save when ordering... |
Store is hidden for testing, replaced with old films page. @eyalcohen , think you're traveling - if not wanna have a look? Lets get this merged and deployed for some test shipments. |
I will buy some shit for testing if you need another test bunny
|
@varmlandsmaskinen that would be sick... will let you know when it's up! |
Hey dude, pretty excited about this. Looks great. Here are some comments:
Minor stuff:
|
Increased the timeout for the failing test, should be good now |
Yep yep, makes sense.
|
Everything you wrote sounds good to me. Getting close! |
review fixes in 688c69e pending store tests... |
fe95365
to
b1199a3
Compare
hey! looks great! I have one really minor thing, which is the 'Gotcha. How Does this Look?' modal should also display the shipping information since its the last opportunity to confirm it. But in general, lets get this live so I can get some brushes :) |
Good call dude. I added the "ships" and "delivered by" dates to the last screen under the shipping carrier section. Also added the order email to the final confirmation. The Shipwire sandbox must function a little differently than the live APIs... I have to manually mark an order as shipped for the first "received at warehouse" email to be kicked off. If this is not the case in the live situation, we'll need to send our own email so they get something from us immediately, not in a couple hours (or days over the weekend) when the order is automatically marked as shipped, but we don't want duplicates about order receiving. In any case, they'll get a billing confirmation email from Stripe. |
WIP: getting closer here, but still work to do mostly around dealing with taxes and shipping rates. Need an intermediate shipping form... we can get shipping estimates from shipwire (like below), which is slick.