fix(serve/start): pass corber_platform. Partial fix to #509

isleofcode · Jul 10, 2018 · 82f35c7 · 82f35c7
1 parent 7c7342a
commit 82f35c7
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 1 deletion.
diff --git a/lib/commands/serve.js b/lib/commands/serve.js
@@ -68,7 +68,8 @@ module.exports = Command.extend({
     this.project.targetIsCordova = true;
     this.project.targetIsCordovaLivereload = true;
     this.project.CORBER_PLATFORM = opts.platform;
-
+    // allows platform-specific tuning in framework build pipeline
+    process.env.CORBER_PLATFORM = opts.platform;
 
     let hook = new Hook({
       project: this.project

diff --git a/lib/commands/start.js b/lib/commands/start.js
@@ -142,6 +142,8 @@ module.exports = Command.extend({
         this.project.targetIsCordova = true;
         this.project.CORBER_PLATFORM = device.platform;
         this.project.targetIsCordovaLivereload = true;
+        // allows platform-specific tuning in framework build pipeline
+        process.env.CORBER_PLATFORM = opts.platform;
 
         cdvTarget.platform = device.platform;
 

diff --git a/node-tests/unit/commands/build-test.js b/node-tests/unit/commands/build-test.js
@@ -199,4 +199,11 @@ describe('Build Command', function() {
       }));
     });
   });
+
+  it('sets process.env.CORBER_PLATFORM', function() {
+    let build = setupBuild();
+    return build.run(baseOpts).then(function() {
+      expect(process.env.CORBER_PLATFORM).to.equal('ios');
+    });
+  });
 });
diff --git a/node-tests/unit/commands/serve-test.js b/node-tests/unit/commands/serve-test.js
@@ -114,6 +114,12 @@ describe('Serve Command', function() {
     });
   });
 
+  it('sets process.env.CORBER_PLATFORM', function() {
+    return serveCmd.run({platform: 'ios'}).then(function() {
+      expect(process.env.CORBER_PLATFORM).to.equal('ios');
+    });
+  });
+
   it('runs tasks in the correct order', function() {
     return serveCmd.run({}).then(function() {
       expect(tasks).to.deep.equal([

diff --git a/node-tests/unit/commands/start-test.js b/node-tests/unit/commands/start-test.js
@@ -198,6 +198,12 @@ describe('Start Command', function() {
         expect(mockProject.project.targetIsCordovaLivereload).to.equal(true);
       });
     });
+
+    it('sets process.env.CORBER_PLATFORM', function() {
+      return start.run({build: false, platform: 'ios'}).then(function() {
+        expect(process.env.CORBER_PLATFORM).to.equal('ios');
+      });
+    });
   });
 
   describe('getReloadURL', function() {