CSS content updates #133
Merged
CSS content updates #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master.next: Moving assets to source folder and updating the build to output them to the _assets folder at the top, nice and tidy like. It strikes me we could even move the /content and /_layout folders to the /src folder, but let's not get crazy today. Revert "remove as-yet-unused _assets folder" Remove unused SCSS files (isobar-us#60) and files related to the js-only css built code (isobar-us#125) Remove external CSS linked by JS call to avoid the HTTP request. Added a few styles to keep it all working when the JS doesn't run.
* master.next: Making sure we've got all the files from the big move ...
This commit includes edits and a simple naming convention based pattern to follow for some projects.
* master.next: Moving content bits, layout bits, and updating Gruntfile Fixing a watch task bug in the Gruntfile introduced when some files were moved. Note: Github online may not show the history, but the history should be preserved by doing a "git log --follow" on any file you wish to check the history for. Moving content source and updating Gruntfile
* master.next: Correction: remove reference to Ruby as it is no longer a dependency. Updates to readme for file paths.
|
Working on #45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of CSS content changes. From here I'd like to solicit feedback from other team members for sure. There is a whole section on a sample naming pattern which may be better pulled out, since it's opinionated — though it is fairly basic and might be good for a starting point.