Add regex for cdn.optimizely.com #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, |
|
When I tried that website a few months ago, the extension was failing due to the cdn.optimizely script - adding it to the regex list fixed it. I visited the url right now and there seems to be no reference to optimizely anymore, so maybe Medium reverted that change. |
|
Hmm interesting. I will keep this PR open for a while and see if I can reproduce this. Because otherwise we would have to target all websites that make a request to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The site:
https://betterprogramming.pub/software-engineers-avoid-being-the-critical-person-on-your-team-b94494f28154
loads from https://cdn.optimizely.com/js/16180790160.js so added a quick regex modification to capture the pattern