Feature/issue 1310 #1596
Merged
Feature/issue 1310 #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulyasaur
approved these changes
Jul 31, 2024
NastiaVeret
approved these changes
Jul 31, 2024
KateYatsiuk
reviewed
Jul 31, 2024
There was a problem hiding this comment.
Please consider comments and pay attention to Sonar Cloud analysis (btw, it's nice that you remembered to test your changes, 100% coverage on new code is something you should always strive for when changing existing code base).
P.S. You can delete CreateStreetcodeHandlerTests.cs file (its content is commented and very old) and as a result you'll be able to rename CreateStreetcodeTests.cs to CreateStreetcodeHandlerTests.cs so that it matches naming pattern.
Streetcode/Streetcode.BLL/MediatR/Streetcode/Streetcode/Create/CreateStreetcodeHandler.cs
Outdated
Show resolved
Hide resolved
Streetcode/Streetcode.XUnitTest/MediatRTests/StreetCode/Streetcode/CreateStreetcodeTests.cs
Outdated
Show resolved
Hide resolved
DmytroHoliaka
approved these changes
Aug 2, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev
Issue
Code reviewers
Second Level Review
Summary of issue
The streetcode is created using invalid indexes
Summary of change
Add rule for index validation
Testing approach
Add test for boundary values
CHECK LIST