Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs #432 for fans valerii #560

Merged
merged 9 commits into from
Aug 7, 2023
Merged

Conversation

ValDekh
Copy link
Contributor

@ValDekh ValDekh commented Aug 4, 2023

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

[Admin/Sources block] An admin can add more than 4000 symbols to the text field #432

Chage text limit from 1000 to 10000 in Text Content field for fan

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@ValDekh ValDekh added bug Something isn't working (Epic#2) Admin/New StreetCode labels Aug 4, 2023
@ValDekh ValDekh requested review from a team August 4, 2023 12:42
@ValDekh ValDekh self-assigned this Aug 4, 2023
Streetcode/StreetCode.Client Outdated Show resolved Hide resolved
Streetcode/Streetcode.WebApi/appsettings.Local.json Outdated Show resolved Hide resolved
Streetcode/Streetcode.WebApi/appsettings.json Outdated Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you add new changes from migration to the script and do you still need migration files that was generated?

Copy link
Contributor Author

@ValDekh ValDekh Aug 7, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we need both

@sonarcloud
Copy link

sonarcloud bot commented Aug 7, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.9% 0.9% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ValDekh ValDekh merged commit 19711ba into develop Aug 7, 2023
2 of 3 checks passed
@ValDekh ValDekh deleted the Fix-bugs-#526-forFans-Valerii- branch October 5, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants