Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix code_verifier length #319

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix code_verifier length #319

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions spid_cie_oidc/relying_party/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,8 @@
import json
import hashlib
import logging
import os
import random
import re
import secrets
import string
import urllib

Expand Down Expand Up @@ -34,10 +33,11 @@ def random_string(n=32):
def get_pkce(code_challenge_method: str = "S256", code_challenge_length: int = 64):
hashers = {"S256": hashlib.sha256}

code_verifier_length = random.randint(43, 128) # nosec - B311
code_verifier = base64.urlsafe_b64encode(os.urandom(code_verifier_length)).decode("utf-8")
code_verifier = re.sub("[^a-zA-Z0-9]+", "", code_verifier)

# https://datatracker.ietf.org/doc/html/rfc7636#section-4.1
code_verifier_length = secrets.choice(range(43, 128 + 1))
alpha = string.ascii_letters + string.digits + "-._~"
code_verifier = "".join([secrets.choice(alpha) for _ in range(code_verifier_length)])

code_challenge = hashers.get(code_challenge_method)(
code_verifier.encode("utf-8")
).digest()
Expand Down
Loading