Any upload is better than no upload #242
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically, if all the uploads get filtered, then the user can't download the app, this PR changes the behavior and if there are no valid uploads left, then it allows the user to choose any of the uploads. How could this be helpful? In my case, I commonly use itch app for game jams, but if the dev doesn't select the appropriate platform, suddenly his game is not downloadable by itch.
This PR changes behavior from this:
To this:
However if dev does specify the platform, then no changes are made and user gets shown only the appropriate ones for his OS.
It might be nice to notify the user about the unknown platform in the itch app, I think I can add that later.