Recognize arm64 as a valid goarch #2928
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The itch app queries the OS for its platform architecture in order to decide which builds of butler and itch-setup to download from broth.itch.ovh. There is a bit of ad-hoc logic in the itch app to translate the architecture string into the format used by Go, which is what butler and itch-setup are written in and packaged with. This ad-hoc logic did not recognize arm64 as a valid architecture, likely because broth.itch.ovh does not currently serve arm64 builds of butler and itch-setup. This commit prepares the itch app for a future where such builds are available.
Author
|
In my manual local tests on my M1 Mac, observed the following behavior change: Before: After: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The itch app queries the OS for its platform architecture in order to decide which builds of butler and itch-setup to download from broth.itch.ovh. There is a bit of ad-hoc logic in the itch app to translate the architecture string into the format used by Go, which is what butler and itch-setup are written in and packaged with. This ad-hoc logic did not recognize arm64 as a valid architecture, likely because broth.itch.ovh does not currently serve arm64 builds of butler and itch-setup. This commit prepares the itch app for a future where such builds are available.