Fix for invoice date last day of month setting #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adjusted invoice model to set config as property in constructor adjusted setClient function to pass config and date to getInvoiceDateFunction invoice-date-strategy: add parameter to getInvoice to receive date of invoice adjusted endofmonth function to handling new logic with given date invoiceModel.spec.ts: add test for testing new endofmonth functionallity => in hindsight this might have been more logically as seperate spec file
Laoujin
reviewed
Jul 3, 2024
JochemVH1
changed the title
Added translations for new strategy Added new case for new strategy and reverted old logic in invoice-date-strategy.ts fixed tests to use new strategy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added fix for #283
Maybe I should have added seperate spec file for the tests