fix(setup): allow non callable values #1070
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying datachain-documentation with
|
| Latest commit: |
cbcfd19
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fbe151c5.datachain-documentation.pages.dev |
| Branch Preview URL: | https://fix-1069-setup-non-callable.datachain-documentation.pages.dev |
shcheklein
force-pushed
the
fix-1069/setup-non-callable
branch
from
036015f to
50e5f1e
Compare
shcheklein
force-pushed
the
fix-1069/setup-non-callable
branch
from
50e5f1e to
cbcfd19
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1070 +/- ##
==========================================
- Coverage 88.14% 88.14% -0.01%
==========================================
Files 146 146
Lines 12508 12505 -3
Branches 1742 1740 -2
==========================================
- Hits 11025 11022 -3
Misses 1059 1059
Partials 424 424
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@dreadatour do you foresee any potential issues in the distributed mode (where we serialize values). As far as I understand now we can serialize callable (do we do this?), while after this change it will be an object. Not sure if there are any issues with this. |
|
@dreadatour when you have a minute, could please take a look :) should be a small PR ... my only question is about serialize / deserialize logic - if it is impacted or not |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1069
Allow regular values in
setup():client=anthropic.Anthropic(api_key=API_KEY)instead of usinglambda:client=lambda: anthropic.Anthropic(api_key=API_KEY)Callable is still supported and cached.
TODO: