Skip to content

partition_by with complex signals - includes agg and group_by #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Jul 12, 2025

Add more tests

09b8a6e
Select commit
Loading
Failed to load commit list.
Merged

partition_by with complex signals - includes agg and group_by #1215

Add more tests
09b8a6e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 12, 2025 in 1s

88.69% (+0.00%) compared to fd3795e

View this Pull Request on Codecov

88.69% (+0.00%) compared to fd3795e

Details

Codecov Report

Attention: Patch coverage is 90.42553% with 9 lines in your changes missing coverage. Please review.

Project coverage is 88.69%. Comparing base (fd3795e) to head (09b8a6e).

Files with missing lines Patch % Lines
src/datachain/lib/dc/datachain.py 92.15% 1 Missing and 3 partials ⚠️
src/datachain/query/dataset.py 76.92% 2 Missing and 1 partial ⚠️
src/datachain/lib/convert/sql_to_python.py 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1215   +/-   ##
=======================================
  Coverage   88.68%   88.69%           
=======================================
  Files         152      152           
  Lines       13606    13680   +74     
  Branches     1893     1909   +16     
=======================================
+ Hits        12067    12133   +66     
- Misses       1093     1099    +6     
- Partials      446      448    +2     
Files with missing lines Coverage Δ
src/datachain/lib/model_store.py 93.84% <100.00%> (+0.29%) ⬆️
src/datachain/lib/signal_schema.py 96.10% <100.00%> (+0.68%) ⬆️
src/datachain/lib/convert/sql_to_python.py 87.50% <60.00%> (-12.50%) ⬇️
src/datachain/query/dataset.py 93.33% <76.92%> (-0.27%) ⬇️
src/datachain/lib/dc/datachain.py 90.16% <92.15%> (+0.07%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.