Skip to content

bench: check for dvc_bin.version instead of dvc_rev #10764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025
Merged

bench: check for dvc_bin.version instead of dvc_rev #10764

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d7ea92
bench: check for dvc_bin.version instead of dvc_rev
skshetry Jun 5, 2025
55cee32
Update dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py
skshetry Jun 5, 2025
2b4f731
Update dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py
skshetry Jun 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions dvc/testing/benchmarks/cli/stories/use_cases/test_sharing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,12 @@
from packaging import version


def test_sharing(bench_dvc, tmp_dir, dvc, make_dataset, remote, dvc_rev):
def test_sharing(bench_dvc, tmp_dir, dvc, make_dataset, remote, dvc_bin):
is_gs = dvc.config["remote"]["upstream"]["url"].startswith("gs://")
if dvc_rev and is_gs and version.Version(dvc_rev) < version.Version("3.59.3"):
# support for allow_anonymous_login in gs was introduced in dvc==3.59.3
if is_gs and version.Version(dvc_bin.version) < version.Version("3.60.0"):
# support for allow_anonymous_login in gs was introduced in dvc==3.60
# This should not impact the test, just that it will make it slower if used
# with fake-gcs-server.
with dvc.config.edit() as d:
d["remote"]["upstream"].pop("allow_anonymous_login", None)

Expand Down
1 change: 1 addition & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ filterwarnings = [
"ignore:nx.nx_pydot.* depends on the pydot package, which has.*known issues and is not actively maintained:DeprecationWarning",
# TODO: investigate where we are not closing sqlite3.Connection
"ignore:unclosed database.*sqlite3.Connection:ResourceWarning",
"ignore:unclosed.*<socket.socket:ResourceWarning",
]
log_level = "debug"
markers = [
Expand Down
Loading