Calldata Optimal Execution mode, with only datas field #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated: IthacaAccount
Contributor
|
🤖 Bytecode changes detected! EIP-712 domain versions have been automatically updated for: IthacaAccount |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new batch execution mode for calls that share a common target address and a 0 value field.
This is calldata optimally efficient for most day to day transaction to the same account. Most DApps don't require the use of a value field in batches. The only thing differing between the executions in the batch are the data fields.
hanges
Core Implementation:
0x0100000000007821000300000000000000000000000000000000000000000000
We have to port over the ERC7821 lib as a vendor lib inside the repository to add these changes, until these are merged in Solady.
Maybe it is better to just port over and own this lib in the long term, as it will allow us to simplify all of the '_execute()' overloading complexity in the account.