chore: add specific error names in Account and Orchestrator #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
howydev
reviewed
Oct 15, 2025
|
|
||
| contract MockPayerWithSignature is Ownable { | ||
| /// @dev Unauthorized orchestrator in pay function. | ||
| error UnauthorizedOrchestrator(); |
Contributor
There was a problem hiding this comment.
could we get a different error here? there's an UnauthorizedOrchestrator in the account already
Author
There was a problem hiding this comment.
Renamed to UnapprovedOrchestrator() in mocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #399
Ran some tests and went ahead with using specific error names without any params as it was around ~20% gas efficient compared to other 2 options (bytes4 and string param w/ custom errors).