docs: resolve TODO for keyHash stack operations #405
+119
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves TODO on line 709 of IthacaAccount.sol regarding where to add keyHash stack push/pop operations after delegate call removal. Analysis shows that push/pop is only needed in execution paths 1 and 3: - Path 1 (Orchestrator workflow): Already has push/pop (lines 685-687) - Path 3 (Simple workflow with opData): Already has push/pop (lines 710-712) Path 2 (Simple workflow without opData) correctly does NOT need push/pop because: - Used for EOA key self-calls (keyHash = bytes32(0)) - Empty stack returns bytes32(0) via getContextKeyHash() - Pushing bytes32(0) explicitly would be redundant Added clarifying comment and test demonstrating correctness. Test: test/TODO_Resolution_Test.t.sol - Validates getContextKeyHash() behavior across paths - Confirms path 2 behavior is correct without push/pop - All existing tests still passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the TODO on line 709 of
IthacaAccount.solregarding where to add keyHash stack push/pop operations after delegate call removal.Analysis
After analyzing all execution paths in
_execute(), determined that push/pop operations are only needed in paths 1 and 3:Why Path 2 Doesn't Need Push/Pop
Path 2 uses EOA key (keyHash =
bytes32(0)) for admin self-calls:bytes32(0)viagetContextKeyHash()bytes32(0)explicitly would be redundantChanges
test/TODO_Resolution_Test.t.sol) demonstrating:getContextKeyHash()in all execution pathsTesting
forge test --match-contract TODO_ResolutionTest -vvResults:
Related
Checklist