feat: React Native SIWE & account upgrade support #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
commit: |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as resolved.
This comment was marked as resolved.
o-az
force-pushed
the
o-az/rn-acct-upgrade-siwe
branch
2 times, most recently
from
4f5fc5d to
a2ab290
Compare
o-az
force-pushed
the
o-az/rn-acct-upgrade-siwe
branch
from
7993dd8 to
5e03969
Compare
o-az
force-pushed
the
o-az/rn-acct-upgrade-siwe
branch
from
5e03969 to
6b0830a
Compare
o-az
changed the title
jxom
reviewed
Nov 1, 2025
| }) | ||
|
|
||
| return { message, signature: signature_erc8010 } | ||
| // If authUrl is provided, authenticate with the server |
Collaborator
There was a problem hiding this comment.
Confirming that we don’t run into the double authenticate issue when using with dialog?
jxom
approved these changes
Nov 1, 2025
Collaborator
jxom
left a comment
jxom
left a comment
There was a problem hiding this comment.
Looks good as long as it still works with existing auth examples and no double authenticate.
o-az
force-pushed
the
o-az/rn-acct-upgrade-siwe
branch
from
9fb5209 to
c24ecf9
Compare
o-az
force-pushed
the
o-az/rn-acct-upgrade-siwe
branch
from
96c21a8 to
126565f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
• SDK
wallet_prepareAccountUpgrade), access towebauthn.createmust be present in the environment, regardless of mode (dialog or not). To cover this, I added a React Native passkey adapter that wiresreact-native-passkeysinto the default relay fallback, handles RP host, and normalizes WebAuthn payload encodingsrc/core/internal/siwe.ts), normalizing domains and preserving existing the React Native bridge and storage cache, preventing fallback to navigator.credentials and caching passkey verification for follow-up signatures.• Dialog
wallet_connectroute to carry the originalsignInWithEthereumobject, filling in domain/URI defaults without destructuring into{}. Also fixes schema error introduced in the prior PR•
react-native-relay-modeexample:Deliverables: