Skip to content

Use correct function name #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jenpaff merged 1 commit into from
Mar 21, 2025
Merged

Use correct function name #6

jenpaff merged 1 commit into from
Mar 21, 2025

Conversation

@jenpaff
Copy link
Contributor

@jenpaff jenpaff commented Mar 20, 2025

should be eth_getHeaderByNumber and eth_getHeaderByHash

fixes errors in workflow https://github.com/ithacaxyz/infra-techops/actions/runs/13966909302/job/39099633414#step:7:53

--- RPC Method Test Results ---

Block Number 7941603 ❌
    getHeaderByNumber: ❌ rpc1: ErrorResp(ErrorPayload { code: -32601, message: "Method not found", data: None })

couple more errors to go

@jenpaff jenpaff requested a review from fgimenez March 20, 2025 19:38
fgimenez
fgimenez approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@fgimenez fgimenez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@jenpaff jenpaff marked this pull request as ready for review March 21, 2025 11:18
@jenpaff jenpaff merged commit 62de030 into main Mar 21, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fgimenez fgimenez fgimenez approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jenpaff @fgimenez