fix electron.server.ts for remix v2... #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without globals, the root.tsx causes server fail with "[remix-electron] TypeError: Headers is not a constructor" see https://remix.run/docs/en/main/start/v2#installglobals
|
Thanks for this! I just merged an update for v2 to fix a bunch of other stuff, including a call to |
|
saw that and upgraded my project with your changes - all working great! |
tonywoode
added a commit
to tonywoode/qp-ag-grid-remix
that referenced
this pull request
Oct 23, 2023
* see itsMapleLeaf/remix-electron#21 * effectively just diffmerged his template against files here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
without globals, the root.tsx causes server fail with "[remix-electron] TypeError: Headers is not a constructor", so the template doesn't load. I believe this is about: see https://remix.run/docs/en/main/start/v2#installglobals
hence adding the globals lets the template's component load and render