Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make code gen compatible with gcc 14.1 #264

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Make code gen compatible with gcc 14.1 #264

merged 1 commit into from
Jun 20, 2024

Conversation

vidsinghal
Copy link
Collaborator

Make the cast explicit from GibCursor to uintptr

ulysses4ever
ulysses4ever approved these changes Jun 20, 2024
View reviewed changes
Copy link
Collaborator

@ulysses4ever ulysses4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, thanks!

I wish we had a CI configuration that exercised this problem (presumably, this means a configuration using GCC14?)

@vidsinghal
Copy link
Collaborator Author

Looks reasonable to me, thanks!

I wish we had a CI configuration that exercised this problem (presumably, this means a configuration using GCC14?)

yeah CI should use gcc 14.1

@vidsinghal vidsinghal merged commit 32723ed into main Jun 20, 2024
18 checks passed
@vidsinghal vidsinghal deleted the make_codegen_gcc_compatible branch June 20, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulysses4ever ulysses4ever ulysses4ever approved these changes

@ckoparkar ckoparkar Awaiting requested review from ckoparkar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vidsinghal @ulysses4ever