Refactor locvar dtype #271
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulysses4ever
reviewed
Nov 2, 2024
Comment on lines
236
to
237
| initFunEnv' :: FunDefs LocVar a -> TyEnv LocVar (ArrowTy (TyOf a)) | ||
| initFunEnv' fds = M.map funTy fds |
There was a problem hiding this comment.
Try to avoid copy-pasting. There may be enough to have a single version of initFunEnv and maybe insertFD, if you use polymorphism. E.g. does this work:
initFunEnv :: FunDefs v a -> TyEnv v (ArrowTy (TyOf a))
initFunEnv fds = M.map funTy fds
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old:
type LocVar = Var
New:
data LocVar = Single Var
This branch is to make the old compiler work and pass test suite but it is only a refactoring PR