[WIP] Adapt changes to upstream embassy-net

[showier-drastic]

Commit embassy-rs/embassy@be0d977 made a rather large change to lifetime/generics semantics to embassy-net. Update edge-nal-embassy to adapt to it.

Tested to compile, but not tested to run yet.

[ivmarkov]

Yes - thank you!

I think we should wait for this PR to get merged as well, as it will bring even more changes to embassy-net (it will switch to the core::net types).

Given that the upstream PR that switches smoltcp to core::net types already got merged, I don't think the embassy-net one would be delayed by a lot, if at all.

[ivmarkov]

Also - you need to run cargo fmt

[AnthonyGrondin]

Thank you for taking care of this. I believe we should also wait for embassy-rs/embassy#3368 as it allows implementing proper readable() / writable() for embassy

[showier-drastic]

Understood, thanks for letting me know!

[AnthonyGrondin]

Both PRs have been merged, so feel free to continue this PR with the needed changes.

Smoltcp and embassy-net haven't had a release yet, at the time of writing this, but we can get by with using patches, I believe.

[showier-drastic]

Both PRs have been merged, so feel free to continue this PR with the needed changes.

Smoltcp and embassy-net haven't had a release yet, at the time of writing this, but we can get by with using patches, I believe.

Nice to hear that, I will update this PR hopefully in a day or two.

[showier-drastic]

Hi @AnthonyGrondin ,

It is not clear to me how to implement readable and writable.

For example, for edge_nal_embassy::tcp::TcpSocketRead you only have embassy_net::tcp::TcpReader inside it; however, in order to call wait_read_ready, you need embassy_net::tcp::TcpSocket.

Maybe we should add wait_read_ready to embassy_net::tcp::TcpReader (and the counterpart for Writer & Udp)?

I'd appreciate it if you could give some suggestions.

[AnthonyGrondin]

I'm not sure if it's a hard requirement to implement readable for edge_nal_embassy::tcp::TcpSocketRead at the moment.

As long as it's implemented for TcpSocket and UdpSocket. For edge_nal_embassy::tcp::TcpSocketRead, it might require more changes to be upstreamed into embassy-net.

@ivmarkov Can comment more on that.

[ivmarkov]

Yes (updated), this is an omission. TcpReader should also have wait_read_ready, and the other way around, for TcpWriter.

[ivmarkov]

And btw same for the UDP socket splits.

[showier-drastic]

It seems that we don't have a Writable trait, so there's no writable for writers.

[ivmarkov]

It seems that we don't have a Writable trait, so there's no writable for writers.

Yes, but regardless of that having wait_write_ready on TcpWriter still makes a lot of sense, outside of edge-nal-embassy and for the cases when you use embassy-net directly.

[ivmarkov]

@showier-drastic this PR just got merged, so if you would like to resume your work here, I think all obstacles should hopefully be cleared by now. :)

Thanks to @AnthonyGrondin

[showier-drastic]

Nice to hear, I will work on it tomorrow.

BTW, I want to know when should this PR supposedly be merged? when next embassy-net is released?

[ivmarkov]

We can branch the repo and merge it earlier.