-
Notifications
You must be signed in to change notification settings - Fork 24
Add single player maps that have mp versions to settings_map #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Hello, I feel like you commited a same line twice on the serverlist filter. Is that a mistake? |
|
Adding that line twice forces the server list to start in "descending players" order |
|
Needs rewrite since the sorting was done from engine code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I answered this on discord but since this is more of the "persistent" place I thought i'd repost it here. TL;DR singleplayer maps need more work to be put in menus along MP maps.
Im not opposed to adding SP maps to menus and allowing them to be picked as regular maps, in their own sections
but for that to happen i will have several requirements.
You might not know it but the ents/scripts we use for SP maps are actually extremely old, more than 10 years old, they were made back in Repz/AIW days. They're working but barely, and they're incomplete - more "proof of concept" than actual releasable thingy. This is why the SP maps have been hidden away since forever, more as a joke ("we did it!") than as a real feature
These would be my requirements:
- Every map must have a proper loading screen/preview image, localized name and description (like MP maps)
- They must have spawn points/entities/etc for every mode they claim to support in basemaps.arena. If they only support TDM/DM, then the basemaps arena should reflect that, otherwise if we want them for Koth/Snd/Demo, then the entities should reflect that
- Currently due to the way their MP ents/Script were crafted back then, they're restricted to a small area, usually not a very interesting one (so_ghillies for instance), so I would ask that the ents/scripts are modified to no longer bar access to the map and that instead the whole map (or let's say, a biggest area possible) is usable. On so_ghillies that should pretty much be from start to finish. (yes it's huge!).
- No script errors, no fog error, no createFX error, the map should run without errors and have the FX it should have
- Compass should work and be correct
As you can see this is quite a list, and despite being only the bare minimum requirements imo to have them be properly integrated, it still represents a lot of work for each and every map. We could maybe add them one by one as they get fixed. But under those conditions i will be perfectly fine adding them to the menu as more "official" kinda, maps
If someone takes on this work for a map and brings a SP map to these requirements, i will gladly deploy these changes. Fortunately it's rawfiles changes only pretty much, so it's something anybody should be able to do 🤔
Additional infos on the missions and their related maps can be found here and here