minor fixups #8
minor fixups #8
Conversation
- fix some menu strings - remove unused game modes from menu - disable teamchange in ffa - private match respect ui_allow_teamchange - disable vote in private match
|
should break the pr down. |
|
I won't be able to make any changes for a few days, but I the meantime I updated the first message to explain the changes better - they are very basic. If you still don't like these changes just let me know and I will discard them as soon as I can. |
Rackover
left a comment
Rackover
left a comment
There was a problem hiding this comment.
Turns out my review of this PR was never posted becasue I forgot to click it, it was stuck in "Pending" and I didn't know. :(
Sorry
| REFERENCE MPUI_GTNW_CAPS | ||
| LANG_ENGLISH "GLOBAL THERMAL NUCLEAR WAR" | ||
|
|
||
| REFERENCE MENU_GTNW |
There was a problem hiding this comment.
I don’t really see anything wrong. These changes were tested before submission so i’m sure they worked at the time. If it’s a matter of consistency I will gladly update the PR
| @@ -1,5 +1,5 @@ | |||
| a0,b1,c2,d3,e4,f5 | |||
| dm,MPUI_DEATHMATCH,MENU_KILL_EVERYONE_FIRST_PLAYER,weapon_missing_image,1,1 | |||
| dm,MPUI_DEATHMATCH,MENU_KILL_EVERYONE_FIRST_PLAYER,weapon_missing_image,0,1 | |||
There was a problem hiding this comment.
Why remove team change in FFA?
Yea it's not very useful, but it allows you to change skin, so I mean why not. Is it a problem that it's allowed?
There was a problem hiding this comment.
iirc this only remove the select a team option upon first joining and will skip right to select a class instead. Pretty sure you can still change teams in the menu itself.
| vip,MPUI_VIP,MENU_VIP,weapon_missing_image,1,1 | ||
| ctf,MPUI_CTF,MENU_CTF_DESC,weapon_missing_image,1,1 | ||
| gtnw,MPUI_GTNW,MENU_GTNW_DESC,weapon_missing_image,1,1 | ||
| gtnw,MPUI_GTNW,MENU_GTNW,weapon_missing_image,1,1 |
There was a problem hiding this comment.
why get rid of the description?
There was a problem hiding this comment.
Description has not been removed. There was a mismatch in naming between this table and the menu scripts. I simply changed the value in the table to match the menu but you could equivalently change the menu to use _DESC instead
|
Hey, sorry for the delay here @WantedDV! Could you walk me through what's still relevant and what might not be? If possible, would you mind creating a follow-up PR to split the changes into smaller pieces that can be reviewed individually? 🫡 |
4 participants
fix gtnw gamesettings menu string. Below is an image of the problem.
remove VIP game mode from menu. There are no scripts for this mode at this time.
non-team game modes no longer ask you to select a team upon joining and skips directly to select-a-class. (The change team option is still available in the ESC menu if team changing is allowed on the server)
restored working
ui_allow_teamchangedvar for private matches. I'm guessing this stopped working when private matches were forced to use online stats.disabled vote in private match