Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespaces: Renamings #805

Open
wants to merge 11 commits into
base: collect-components-of-namespaces
Choose a base branch
from

Conversation

MImmesberger
Copy link
Collaborator

What problem do you want to solve?

This PR provides the necessary renamings of taxes and transfers functions for #804.

@MImmesberger MImmesberger mentioned this pull request Dec 19, 2024
@MImmesberger
Copy link
Collaborator Author

MImmesberger commented Dec 21, 2024

I have finished renaming all taxes. (I will postpone transforming the qualified names in the tests to a tree structure until the very last step, it's hard to make changes after that.)

@hmgaudecker a style question: Do you have an opinion about how we handle cases where the qualified names are longer than 88 characters?

In the sozialversicherungsbeitraege/pflegeversicherung/__init__.py module we have:

@policy_info(
    start_date="1995-01-01",
    end_date="2004-12-31",
    name_in_dag="betrag_selbständig_m",
)
def betrag_selbständig_ohne_zusatz_fuer_kinderlose_m(
    sozialversicherungsbeitraege__krankenversicherung__einkommen__bemessungsgrundlage_selbständig_m: float,
    sozialversicherungsbeitraege__pflegeversicherung__beitragssatz__betrag: float,
) -> float:
    """Self-employed individuals' long-term care insurance contribution until 2004.

I'd say its better to make an exception to the rule here than to remove nesting levels or use abbreviations. Do you agree?

@hmgaudecker
Copy link
Collaborator

Scary! But yes, most definitely agree! Just append a # noqa... to that line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants