Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop through all nested configs #335

Merged
merged 2 commits into from
May 22, 2024
Merged

Loop through all nested configs #335

merged 2 commits into from
May 22, 2024

Conversation

jacebrowning
Copy link
Owner

@jacebrowning jacebrowning commented May 20, 2024

Fixes #337


@DavidWatkins can you remind me the purpose of the function I removed in this pull request? As far as I can tell the alpha release from this branch is behaving as I expect in relation to nested configs but main is not.

@jacebrowning jacebrowning force-pushed the use-all-configs branch 2 times, most recently from 961780f to 97bc822 Compare May 20, 2024 23:30
Repository owner deleted a comment from codecov bot May 20, 2024
@DavidWatkins
Copy link
Collaborator

@jacebrowning This was removing any configs that come in from any pulled dependencies but still allowed subdirectories to be included for aggregating configs. I would not remove it. What is the behavioral difference you are observing?

@jacebrowning
Copy link
Owner Author

@DavidWatkins I opened #337 to show how to reproduce the behavioral difference.

@DavidWatkins
Copy link
Collaborator

@jacebrowning Ah I see. It's been a year and I cannot remember exactly why I wanted recursion over directories without automatically cloning those sub-dependency gitman.yml files, but with fresh eyes, it makes more sense to allow for this behavior. Go ahead and push this change and we'll make changes on our end to support the new workflow if it breaks anything.

@jacebrowning
Copy link
Owner Author

@DavidWatkins thanks for taking a look! I'll release this as 3.5.2 and please open an issue if you notice any strange behavior.

@jacebrowning jacebrowning marked this pull request as ready for review May 22, 2024 11:05
@jacebrowning jacebrowning merged commit 6e7f40c into main May 22, 2024
10 of 11 checks passed
@jacebrowning jacebrowning deleted the use-all-configs branch May 22, 2024 11:28
Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.07%. Comparing base (16cfe3c) to head (d1c1917).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   91.36%   91.07%   -0.30%     
==========================================
  Files          15       15              
  Lines        1193     1176      -17     
  Branches      243      238       -5     
==========================================
- Hits         1090     1071      -19     
- Misses         70       71       +1     
- Partials       33       34       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested projects are skipped
2 participants