replace kwargs double backslash for multiline messages #294
Conversation
|
There was a problem hiding this comment.
Hi @leonbuchnerbd
thank you for your contribution.
I left you a comment here with some changes I think are worth doing and I think the linter isn't happy. That should be easy to fix with black.
| @@ -83,6 +83,12 @@ def call_api_get(self, method, api_path=None, **kwargs): | |||
| ) | |||
|
|
|||
| def call_api_post(self, method, files=None, use_json=None, **kwargs): | |||
| if "text" in kwargs: | |||
There was a problem hiding this comment.
Could you please extract this into a separate function that sanitizes the text and add a comment/docstring with what the purpose of it is.
It'll make it easier to keep track of it in the future.
I'd also like to see this tested if possible.
Eg: in
rocketchat_API/tests/test_chat.py
Line 14 in b4c4c88
Or create a new test for this purpose altogether.
A better place to place this cleanup could be the
chat_post_message function itself since text is not used anywhere else.Another use I could think of is when text is used in attachments like what we do here:
rocketchat_API/tests/test_chat.py
Line 19 in b4c4c88
That use-case would not be taken into account.
rocketchat_API/APISections/base.py line 86
if you want to use the api to send multiline messages, you have to adapt the kwargs arguments.
the kwargs arguments are json serialized and have problems with escape sequences.
I fixed this here.