Replace command line args in deployment doc #751
Conversation
Signed-off-by: Jonah Kowall <[email protected]>
✅ Deploy Preview for romantic-neumann-1959d7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| -p5778:5778/tcp \ | ||
| jaegertracing/jaeger-agent:{{< currentVersion >}} \ | ||
| --reporter.grpc.host-port=jaeger-collector.jaeger-infra.svc:14250 | ||
| jaeger_storage: |
There was a problem hiding this comment.
We have dedicated pages for each storage backend now, I would rather consolidate everything about that backend there, including config examples. This page could be just about different deployment roles, how they are different, the ports, the APIs exposed.
There was a problem hiding this comment.
I put the snippets here just to provide some guidance. If you want me to just point to the storage pages, I can do that. Please clarify.
There was a problem hiding this comment.
Yes, I would put them in the storage pages and link from here. I don't think we should focus so much on the backends in this top page.
| jaegertracing/jaeger-query:{{< currentVersion >}} | ||
| ``` | ||
|
|
||
| !!! NEED TO FIX 2 sections BELOW | ||
| ### Clock Skew Adjustment |
There was a problem hiding this comment.
need to move elsewhere, this is not a "deployment" section. Technically it belongs to query/UI role, so could move there.
There was a problem hiding this comment.
Do you want me to put an example UI/query role here for the deployment instead? I can add the snippets.
There was a problem hiding this comment.
we need to mention the UI/query role on this page, but the actual configuration details can go to its own dedicated paged.
Signed-off-by: Jonah Kowall <[email protected]>
|
Should be done with the updates and examples. This should fix : #750 |
Signed-off-by: Yuri Shkuro <[email protected]>
Which problem is this PR solving?
Part of #750
Description of the changes
Adjusting command line and other components from v1 to v2.
Checklist