[jaeger][v2] Allow Configurable path for livenessProbe and readinessProbe in hotrod deployment template #647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chahat sagar <[email protected]>
chahatsagarmain
requested review from
naseemkullah and
pavelnikolov
as code owners
chahatsagarmain
changed the title
yurishkuro
approved these changes
Jul 19, 2025
Member
|
why did lint steps fail? |
Contributor
Author
This is the error in the ci test fails @yurishkuro |
Member
|
The last time these lints ran 9 months ago. It looks like it's complaining about python version, we can probably bump it to later version (as a separate PR) |
yurishkuro
approved these changes
Jul 19, 2025
Signed-off-by: chahat sagar <[email protected]>
yurishkuro
approved these changes
Jul 19, 2025
yurishkuro
added a commit
that referenced
this pull request
Dec 2, 2025
* Jaeger v2 with v1 (#613) * Jaeger allInOne allow different storage types (#603) Signed-off-by: Reddysekhar Gaduputi <[email protected]> upgrade jaeger-operator to latest 1.61.0 (#605) Signed-off-by: Blair Bowden <[email protected]> added all-in-one deployment and configmap for jaeger-v2 Signed-off-by: Mehul <[email protected]> lint fix Signed-off-by: Mehul <[email protected]> fixed Signed-off-by: Mehul <[email protected]> lint fix Signed-off-by: Mehul <[email protected]> lint fix Signed-off-by: Mehul <[email protected]> fixed using pre-hook Signed-off-by: Mehul <[email protected]> fixed --config flag is not been passed Signed-off-by: mehul <[email protected]> release ns for config-map.yaml Signed-off-by: mehul <[email protected]> testing ci Signed-off-by: mehul <[email protected]> testing ci Signed-off-by: mehul <[email protected]> fixed ns Signed-off-by: mehul <[email protected]> fixed ns Signed-off-by: mehul <[email protected]> fixed template Signed-off-by: mehul <[email protected]> removed sampling Signed-off-by: mehul <[email protected]> removed adaptive sampling from processors Signed-off-by: mehul <[email protected]> Revert "Jaeger v2 test2" Signed-off-by: mehul <[email protected]> attempt to create v2 chart in v1 Signed-off-by: mehul <[email protected]> enabled collector query and agent Signed-off-by: mehul <[email protected]> version bump Signed-off-by: mehul <[email protected]> testing-v2-ci Signed-off-by: mehul <[email protected]> testing-v2-ci Signed-off-by: mehul <[email protected]> added --helm-extra-set-args flag Signed-off-by: mehul <[email protected]> fixed healthcheck port-v2 Signed-off-by: mehul <[email protected]> Fix health check path Signed-off-by: Yuri Shkuro <[email protected]> minor changes Signed-off-by: mehul <[email protected]> * minor changes Signed-off-by: mehul <[email protected]> * added image changes Signed-off-by: mehul <[email protected]> * fix lint Signed-off-by: mehul <[email protected]> * removed v1 allInOne and added jaeger-v2 Signed-off-by: mehul <[email protected]> * removed v2 references Signed-off-by: mehul <[email protected]> * added allInOne again Signed-off-by: mehul <[email protected]> * minor fix Signed-off-by: mehul <[email protected]> * fixed how the config is being passed Signed-off-by: mehul <[email protected]> * fixed mirror template change Signed-off-by: mehul <[email protected]> * use --set-file for user config Signed-off-by: mehul <[email protected]> * removed config-test and updated configmap template Signed-off-by: mehul <[email protected]> * fixed Signed-off-by: mehul <[email protected]> * fixed minor naming Signed-off-by: mehul <[email protected]> * indentation Signed-off-by: Yuri Shkuro <[email protected]> --------- Signed-off-by: mehul <[email protected]> Signed-off-by: mehul gautam <[email protected]> Signed-off-by: mehul <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Reddysekhar Gaduputi <[email protected]> Co-authored-by: mehul <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> * [jaeger-v2] Add support for Elasticsearch (#617) * Jaeger allInOne allow different storage types (#603) Signed-off-by: Reddysekhar Gaduputi <[email protected]> upgrade jaeger-operator to latest 1.61.0 (#605) Signed-off-by: Blair Bowden <[email protected]> added all-in-one deployment and configmap for jaeger-v2 Signed-off-by: Mehul <[email protected]> lint fix Signed-off-by: Mehul <[email protected]> fixed Signed-off-by: Mehul <[email protected]> lint fix Signed-off-by: Mehul <[email protected]> lint fix Signed-off-by: Mehul <[email protected]> fixed using pre-hook Signed-off-by: Mehul <[email protected]> fixed --config flag is not been passed Signed-off-by: mehul <[email protected]> release ns for config-map.yaml Signed-off-by: mehul <[email protected]> testing ci Signed-off-by: mehul <[email protected]> testing ci Signed-off-by: mehul <[email protected]> fixed ns Signed-off-by: mehul <[email protected]> fixed ns Signed-off-by: mehul <[email protected]> fixed template Signed-off-by: mehul <[email protected]> removed sampling Signed-off-by: mehul <[email protected]> removed adaptive sampling from processors Signed-off-by: mehul <[email protected]> Revert "Jaeger v2 test2" Signed-off-by: mehul <[email protected]> attempt to create v2 chart in v1 Signed-off-by: mehul <[email protected]> enabled collector query and agent Signed-off-by: mehul <[email protected]> version bump Signed-off-by: mehul <[email protected]> testing-v2-ci Signed-off-by: mehul <[email protected]> testing-v2-ci Signed-off-by: mehul <[email protected]> added --helm-extra-set-args flag Signed-off-by: mehul <[email protected]> fixed healthcheck port-v2 Signed-off-by: mehul <[email protected]> Fix health check path Signed-off-by: Yuri Shkuro <[email protected]> minor changes Signed-off-by: mehul <[email protected]> * minor changes Signed-off-by: mehul <[email protected]> * added image changes Signed-off-by: mehul <[email protected]> * fix lint Signed-off-by: mehul <[email protected]> * removed v1 allInOne and added jaeger-v2 Signed-off-by: mehul <[email protected]> * removed v2 references Signed-off-by: mehul <[email protected]> * added allInOne again Signed-off-by: mehul <[email protected]> * minor fix Signed-off-by: mehul <[email protected]> * fixed how the config is being passed Signed-off-by: mehul <[email protected]> * fixed mirror template change Signed-off-by: mehul <[email protected]> * use --set-file for user config Signed-off-by: mehul <[email protected]> * removed config-test and updated configmap template Signed-off-by: mehul <[email protected]> * fixed Signed-off-by: mehul <[email protected]> * fixed minor naming Signed-off-by: mehul <[email protected]> * indentation Signed-off-by: Yuri Shkuro <[email protected]> * v2-elasticsearch Signed-off-by: mehul <[email protected]> * fix ci Signed-off-by: mehul <[email protected]> * fix ci Signed-off-by: mehul <[email protected]> * fixed Signed-off-by: mehul <[email protected]> * fixed and added docs Signed-off-by: mehul <[email protected]> * fixed Signed-off-by: mehul <[email protected]> * added port Signed-off-by: mehul <[email protected]> * fixed Signed-off-by: mehul <[email protected]> * fixed Signed-off-by: mehul <[email protected]> * fixed typo Signed-off-by: mehul <[email protected]> * fixed Signed-off-by: mehul <[email protected]> * removed test config Signed-off-by: mehul <[email protected]> * updated docs Signed-off-by: mehul <[email protected]> --------- Signed-off-by: mehul <[email protected]> Signed-off-by: mehul gautam <[email protected]> Signed-off-by: mehul <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Reddysekhar Gaduputi <[email protected]> Co-authored-by: mehul <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> * bump python (#649) * Allow Configurable path for livenessProbe and readinessProbe in hotrod (#647) Signed-off-by: chahat sagar <[email protected]> * [jaeger] Add default probes path for hotrod (#651) * add deafult path Signed-off-by: chahat sagar <[email protected]> * fix Signed-off-by: chahat sagar <[email protected]> * add deafult path Signed-off-by: chahat sagar <[email protected]> --------- Signed-off-by: chahat sagar <[email protected]> * add ui-config (#654) * Remove Operator chart Signed-off-by: Yuri Shkuro <[email protected]> * Fix ES test by overriding Bitnami images Elasticsearch subchart (#661) * Fix ES test by overriding Bitnami images for provisioned Elasticsearch Signed-off-by: danish9039 <[email protected]> * . Signed-off-by: danish9039 <[email protected]> --------- Signed-off-by: danish9039 <[email protected]> * Update README to remove Jaeger-v2 note Removed outdated note about Helm Chart for Jaeger-v2. Signed-off-by: Yuri Shkuro <[email protected]> * Update main chart's README to reflect v2 specifics (#663) * Initial plan * Merge README files for Jaeger v2 chart - Updated introduction to reflect Jaeger v2 architecture (unified binary on OTel Collector framework) - Updated default deployment description (allInOne mode with memory storage) - Added new YAML-based configuration section showing OTel Collector format - Added userconfig parameter documentation - Updated storage configuration to use jaeger_storage extension format - Added Storage Configuration Options with primary and archive store settings - Updated Elasticsearch installation examples for v2 architecture - Added notes about legacy components (Cassandra, Ingester, grpc-plugin) - Added Separate Collector and Query Mode section for production deployments - Removed outdated references to jaeger-agent DaemonSet as default - Updated dependency documentation (removed deprecated incubator repo) - Fixed typo: "Offical" -> "Official" Co-authored-by: yurishkuro <[email protected]> * Create merged README.md for Jaeger v2 chart (from v2 branch) Merged content from README.md and README-v2.md in the v2 branch: - Updated introduction to reflect Jaeger v2 architecture (unified binary on OTel Collector framework) - Updated default deployment description (allInOne mode with memory storage) - Added new YAML-based configuration section showing OTel Collector format - Added userconfig parameter documentation - Updated storage configuration to use jaeger_storage extension format - Added Storage Configuration Options with primary and archive store settings - Updated Elasticsearch installation examples for v2 architecture - Added notes about legacy components (Cassandra, Ingester, grpc-plugin) - Added Separate Collector and Query Mode section for production deployments - Removed outdated references to jaeger-agent DaemonSet as default - Updated dependency documentation (removed deprecated incubator repo) - Fixed typo: "Offical" -> "Official" - Fixed typo: "Updating to Kafka to" -> "Updating Kafka to" Note: README-v2.md should be deleted from v2 branch after merging this PR Co-authored-by: yurishkuro <[email protected]> --------- Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: yurishkuro <[email protected]> --------- Signed-off-by: mehul <[email protected]> Signed-off-by: mehul gautam <[email protected]> Signed-off-by: mehul <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: chahat sagar <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: danish9039 <[email protected]> Co-authored-by: mehul gautam <[email protected]> Co-authored-by: Reddysekhar Gaduputi <[email protected]> Co-authored-by: mehul <[email protected]> Co-authored-by: chahat sagar <[email protected]> Co-authored-by: hippie-danish <[email protected]> Co-authored-by: copilot-swe-agent[bot] <[email protected]> Co-authored-by: yurishkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Checklist
[jaeger]or[jaeger-operator])