Skip to content
This repository has been archived by the owner on Sep 10, 2024. It is now read-only.

Add basic docker-compose.yaml for Jupyter notebooks #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fktkrt
Copy link

@fktkrt fktkrt commented Oct 26, 2020

This can make easier to spin up a test infrastructure for jupyter testing.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this different from instructions here: https://github.com/jaegertracing/jaeger-analytics-java#run-jupyter-as-docker ?

Please add appropriate documentation.

@@ -0,0 +1,27 @@
version: '3'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would make more sense in the jupyter directory.

@fktkrt
Copy link
Author

fktkrt commented Oct 26, 2020

How is this different from instructions here: https://github.com/jaegertracing/jaeger-analytics-java#run-jupyter-as-docker ?

It provides a way to pull up all components without building the project. It's almost identical, but this can be more convenient for some.
The idea came from #53, because that had individual docker commands in it, compared to those, a docker-compose is more simple.

I'd say merging this w/ #53 can make sense (if the idea of adding a separate deploy method is welcomed), as that has the instructions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants