Skip to content

Commit

Permalink
Add Go type mapping for new timestamp fields from #95 (#98)
Browse files Browse the repository at this point in the history
* Add Go type mapping for new timestamp fields from #95

Signed-off-by: Yuri Shkuro <[email protected]>

* fix

Signed-off-by: Yuri Shkuro <[email protected]>

* import

Signed-off-by: Yuri Shkuro <[email protected]>

---------

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Sep 10, 2023
1 parent 5ee5dbb commit 5b86620
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
16 changes: 12 additions & 4 deletions proto/api_v2/query.proto
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,13 @@ message GetTraceRequest {
(gogoproto.customname) = "TraceID"
];
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2;
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3;
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
];
}

message SpansResponseChunk {
Expand All @@ -59,9 +63,13 @@ message ArchiveTraceRequest {
(gogoproto.customname) = "TraceID"
];
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2;
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3;
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
];
}

message ArchiveTraceResponse {
Expand Down
9 changes: 7 additions & 2 deletions proto/api_v3/query_service.proto
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ syntax="proto3";
package jaeger.api_v3;

import "opentelemetry/proto/trace/v1/trace.proto";
import "gogoproto/gogo.proto";
import "google/protobuf/timestamp.proto";
import "google/protobuf/duration.proto";

Expand All @@ -28,9 +29,13 @@ message GetTraceRequest {
// Hex encoded 64 or 128 bit trace ID.
string trace_id = 1;
// Optional. The start time to search trace ID.
google.protobuf.Timestamp start_time = 2;
google.protobuf.Timestamp start_time = 2 [
(gogoproto.stdtime) = true
];
// Optional. The end time to search trace ID.
google.protobuf.Timestamp end_time = 3;
google.protobuf.Timestamp end_time = 3 [
(gogoproto.stdtime) = true
];
}

// Response object with spans.
Expand Down

0 comments on commit 5b86620

Please sign in to comment.