Skip to content

Commit

Permalink
Require Node version 20+ (#2274)
Browse files Browse the repository at this point in the history
## Which problem is this PR solving?
#2272 

## Description of the changes
- 

## How was this change tested?
- 

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `yarn lint` and `yarn test`

---------

Signed-off-by: Baalekshan <[email protected]>
  • Loading branch information
Baalekshan authored Apr 20, 2024
1 parent c2f4085 commit 13c8591
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 12 deletions.
8 changes: 0 additions & 8 deletions .eslintignore

This file was deleted.

9 changes: 9 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@ module.exports = {
jest: true,
jasmine: true,
},
// Add any other files or directories you want to ignore
ignorePatterns: [
'build/',
'coverage/',
'packages/plexus/src/LayoutManager/layout.worker*js*',
'packages/jaeger-ui/index.d.ts',
'packages/plexus/dist/',
'packages/plexus/lib/',
],
settings: {
'import/resolver': {
node: {
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
cache: yarn
node-version: '18'
node-version: '20'
- run: yarn install --frozen-lockfile
- name: Run depcheck
run: yarn run depcheck
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
cache: yarn
node-version: '18'
node-version: '20'
- run: yarn install --frozen-lockfile
- run: yarn lint
- run: yarn build
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/unit-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
with:
cache: yarn
node-version: '18'
node-version: '20'
- run: yarn install --frozen-lockfile
- run: yarn coverage
- name: Upload coverage to codecov.io
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
engine-strict=true
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
18
20
3 changes: 3 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@
"type": "git",
"url": "https://github.com/jaegertracing/jaeger-ui.git"
},
"engines": {
"node": ">=20"
},
"devDependencies": {
"@babel/eslint-parser": "^7.24.1",
"@typescript-eslint/eslint-plugin": "7.4.0",
Expand Down

0 comments on commit 13c8591

Please sign in to comment.