Speed up Critical path calculation #1975
Conversation
Signed-off-by: Maksim Gaponov <[email protected]>
| criticalPath: criticalPathSection[] | ||
| ): criticalPathSection[] => { | ||
| const currentSpan: Span = spanMap.get(spanId)!; | ||
| let criticalPathBoundary = currentSpan.startTime + currentSpan.duration; |
There was a problem hiding this comment.
confusing name, boundary can be either top or bottom
| spanId: currentSpan.spanID, | ||
| section_start: childEndTime, | ||
| section_end: criticalPathBoundary, | ||
| }; |
There was a problem hiding this comment.
I don't follow. criticalPathBoundary is initially end-of-parent. This says if the child ends before than, then the difference between child.end and parent.end is the critical path contributed by that span?
| reference => reference.refType === 'CHILD_OF' | ||
| )[0].spanID; | ||
| computeCriticalPath(spanMap, parentSpanId, criticalPath, currentSpan.startTime); | ||
| for (let i = 0; i < currentSpan.childSpanIds.length; i++) { |
There was a problem hiding this comment.
is there an assumption on the order of this array?
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time. |
|
This pull request has been automatically closed due to inactivity. You may re-open it if you need more time. We really appreciate your contribution and we are sorry that this has not been completed. |
2 participants
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:yarn lintandyarn test