Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] OTEL / Prom metrics benchmark #5676

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

[WIP] OTEL / Prom metrics benchmark #5676

wants to merge 23 commits into from
+131 −0

Commits on Jun 19, 2024

  1. Instantiated OTEL Metrics 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    f1f9b7a View commit details
    Browse the repository at this point in the history

  2. Ran make fmt 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    12403b1 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. Merge branch 'main' into OTEL_Metrics

    @Wise-Wizard
    Wise-Wizard authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    175efa3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into OTEL_Metrics

    @Wise-Wizard
    Wise-Wizard authored Jun 20, 2024
    Configuration menu
    Copy the full SHA
    443858f View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2024

  1. Create otelmetrics package 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 21, 2024
    Configuration menu
    Copy the full SHA
    0a073b6 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into OTEL_Metrics

    @Wise-Wizard
    Wise-Wizard authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    aa92107 View commit details
    Browse the repository at this point in the history

  3. Update pkg/metrics/otelmetrics/factory.go 

    Co-authored-by: Yuri Shkuro <[email protected]>
Signed-off-by: Saransh Shankar <[email protected]>
    @Wise-Wizard @yurishkuro
    Wise-Wizard and yurishkuro authored Jun 21, 2024
    Configuration menu
    Copy the full SHA
    7efd9b9 View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2024

  1. Created benchmark to compare metric implementation 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    a70d64a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'OTEL_Metrics' of https://github.com/Wise-Wizard/jaeger … 

    …into OTEL_Metrics
    @Wise-Wizard
    Wise-Wizard committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    2ab543b View commit details
    Browse the repository at this point in the history

  3. Resolved conflicts 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    dc2a9ed View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into OTEL_Metrics

    @Wise-Wizard
    Wise-Wizard authored Jun 22, 2024
    Configuration menu
    Copy the full SHA
    f508b8a View commit details
    Browse the repository at this point in the history

  5. avoid allocations 

    tested via
```
$ go test -benchmem -benchtime=5s -bench=Benchmark ./internal/metrics/
```

before:
```
BenchmarkPrometheusCounter-10           856818336                6.875 ns/op           0 B/op          0 allocs/op
BenchmarkOTELCounter-10                 146044255               40.92 ns/op           32 B/op          2 allocs/op
```

after:
``
BenchmarkPrometheusCounter-10           855046669                6.924 ns/op           0 B/op          0 allocs/op
BenchmarkOTELCounter-10                 293330721               21.05 ns/op           16 B/op          1 allocs/op
```

Signed-off-by: Yuri Shkuro <[email protected]>
    @yurishkuro
    yurishkuro committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    4a99291 View commit details
    Browse the repository at this point in the history

  6. Implemented changes 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 22, 2024
    Configuration menu
    Copy the full SHA
    099ba05 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2024

  1. Merge branch 'main' into OTEL_Metrics

    @Wise-Wizard
    Wise-Wizard authored Jun 23, 2024
    Configuration menu
    Copy the full SHA
    21c14b4 View commit details
    Browse the repository at this point in the history

  2. Used metrics.NullCounter as return type 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    8b47b12 View commit details
    Browse the repository at this point in the history

  3. Created rough implementation of OTEL SDK 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 23, 2024
    Configuration menu
    Copy the full SHA
    8032ce2 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2024

  1. Fixed initialization errors 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    6ec5ec4 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into OTEL_Metrics

    @Wise-Wizard
    Wise-Wizard authored Jun 24, 2024
    Configuration menu
    Copy the full SHA
    33d5855 View commit details
    Browse the repository at this point in the history

  3. Made suggested changes 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    4e7dcbb View commit details
    Browse the repository at this point in the history

  4. Created Prometheus Exporter 

    Signed-off-by: Wise-Wizard <[email protected]>
    @Wise-Wizard
    Wise-Wizard committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    f29cad5 View commit details
    Browse the repository at this point in the history

  5. OTEL / Prom metrics benchmark 

    Signed-off-by: Yuri Shkuro <[email protected]>
    @yurishkuro
    yurishkuro committed Jun 24, 2024
    Configuration menu
    Copy the full SHA
    723d74a View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. add-census 

    Signed-off-by: Yuri Shkuro <[email protected]>
    @yurishkuro
    yurishkuro committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c8735f6 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. more 

    Signed-off-by: Yuri Shkuro <[email protected]>
    @yurishkuro
    yurishkuro committed Jul 2, 2024
    Configuration menu
    Copy the full SHA
    d04050c View commit details
    Browse the repository at this point in the history