[v2][adjuster] Implement function to get standard adjusters to operate on otlp format #6396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
Signed-off-by: Mahad Zaryab <[email protected]>
13 tasks
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
reviewed
Dec 23, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6396 +/- ##
==========================================
+ Coverage 96.24% 96.28% +0.04%
==========================================
Files 365 366 +1
Lines 20907 20918 +11
==========================================
+ Hits 20121 20140 +19
+ Misses 601 595 -6
+ Partials 185 183 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 23, 2024
| ClockSkew(maxClockSkewAdjust), // adds warnings (which affect SpanHash) on duplicate span IDs | ||
| IPAttribute(), | ||
| ResourceAttributes(), | ||
| SpanLinks(), |
There was a problem hiding this comment.
We should consider renaming these adjusters to reflect the business function. Reading this list I can reasonably guess what the first two are doing, plus ClockSkew. But all others are poorly named.
My suggestion would be to use verbs that describe the function, e.g.
- DedupeClientServerSpanIDs
- SortAttributes
- DedupeSpans
- etc
There was a problem hiding this comment.
@yurishkuro Done. Let me know what you think
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Dec 23, 2024
Signed-off-by: Mahad Zaryab <[email protected]>
yurishkuro
approved these changes
Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
StandardAdjustersthat returns a list of adjusters to be applied on ptrace.TracesChecklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test