Skip to content

Conversation

yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Feb 8, 2025

Which problem is this PR solving?

Description of the changes

  • Introduce an opt-in option to allow the engine to operate without sampler tags

How was this change tested?

  • TBD

@yurishkuro yurishkuro requested a review from a team as a code owner February 8, 2025 14:18
@dosubot dosubot bot added the area/sampling label Feb 8, 2025
Signed-off-by: Yuri Shkuro <[email protected]>
Copy link

codecov bot commented Feb 8, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.08%. Comparing base (9d1e94c) to head (60d171a).
⚠️ Report is 253 commits behind head on main.

Files with missing lines Patch % Lines
...pling/samplingstrategy/adaptive/post_aggregator.go 66.66% 2 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (78.57%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6692      +/-   ##
==========================================
- Coverage   96.14%   96.08%   -0.07%     
==========================================
  Files         358      358              
  Lines       21584    21582       -2     
==========================================
- Hits        20752    20736      -16     
- Misses        627      637      +10     
- Partials      205      209       +4     
Flag Coverage Δ
badger_v1 9.91% <ø> (ø)
badger_v2 2.05% <ø> (ø)
cassandra-4.x-v1-manual 14.91% <ø> (ø)
cassandra-4.x-v2-auto 2.04% <ø> (ø)
cassandra-4.x-v2-manual 2.04% <ø> (ø)
cassandra-5.x-v1-manual 14.91% <ø> (ø)
cassandra-5.x-v2-auto 2.04% <ø> (ø)
cassandra-5.x-v2-manual 2.04% <ø> (ø)
elasticsearch-6.x-v1 20.17% <ø> (ø)
elasticsearch-7.x-v1 20.25% <ø> (ø)
elasticsearch-8.x-v1 20.43% <ø> (ø)
elasticsearch-8.x-v2 2.05% <ø> (ø)
grpc_v1 11.46% <ø> (ø)
grpc_v2 2.05% <ø> (ø)
kafka-3.x-v1 10.19% <ø> (ø)
kafka-3.x-v2 2.05% <ø> (ø)
memory_v2 2.05% <ø> (ø)
opensearch-1.x-v1 20.30% <ø> (ø)
opensearch-2.x-v1 20.30% <ø> (ø)
opensearch-2.x-v2 2.05% <ø> (ø)
query 2.05% <ø> (ø)
tailsampling-processor 0.55% <ø> (ø)
unittests 94.88% <78.57%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro changed the title Relax adaptive sampling dependency on samlper tags Relax adaptive sampling dependency on sampler tags Feb 12, 2025
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time.

@github-actions github-actions bot added the stale The issue/PR has become stale and may be auto-closed label Jul 28, 2025
@github-actions github-actions bot removed the stale The issue/PR has become stale and may be auto-closed label Aug 4, 2025
Copy link

github-actions bot commented Oct 6, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. You may re-open it if you need more time.

@github-actions github-actions bot added the stale The issue/PR has become stale and may be auto-closed label Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sampling changelog:bugfix-or-minor-feature stale The issue/PR has become stale and may be auto-closed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant