-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[FEATURE]: Automate release steps as requested in #7500 #7502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[FEATURE]: Automate release steps as requested in #7500 #7502
Conversation
Hi @yurishkuro @joe-elliott
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- remove powershell, we do not use Windows for release
- the release starts with
bash scripts/release/start.sh
which creates an issue with the checklist. That checklist needs to be slightly fixed to specify the right versions in the right places (which are already determined when running start.sh) - The checklist needs to include the new automation steps as exact commands to be run
- Don't call scripts "automate-release", it's a meaningless name. Call by the action they are actually doing.
- Remove the README. The release instructions are in the root RELEASES.md
6a8df9a
to
6ca1ce4
Compare
Hi @yurishkuro |
Signed-off-by: ADITYA TIWARI <[email protected]>
Signed-off-by: ADITYA TIWARI <[email protected]>
Signed-off-by: ADITYA TIWARI <[email protected]>
Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: ADITYA TIWARI <[email protected]>
…tion - Add prepare.sh script for automated release PR creation - Automate changelog generation and CHANGELOG.md updates - Automate jaeger-ui submodule updates to latest main - Add tag creation automation with user confirmation - Update start.sh to provide exact commands with versions - Simplify RELEASE.md documentation for automated workflow Implements jaegertracing#7500 Usage: - Create tracking issue: bash scripts/release/start.sh - Create release PR: bash ./scripts/release/prepare.sh v1.x.x v2.x.x - Create tags: bash ./scripts/release/prepare.sh v1.x.x v2.x.x --create-tags Signed-off-by: ADITYATIWARI342005 <[email protected]>
Signed-off-by: ADITYATIWARI342005 <[email protected]>
Signed-off-by: ADITYA TIWARI <[email protected]>
Hi @yurishkuro However, based on these realisations, and all the reviews you gave till now, I have made optimal changes with refrence to the steps mentioned in the issue description #7500 . Please review this optimal approached Implementation, Thank you. |
…cted in review Signed-off-by: ADITYA TIWARI <[email protected]>
Implements automated release steps for Jaeger per #7500: auto-create release PR with changelog and UI upgrade, automate tag creation with user confirmation, and keep final release + artifacts workflow manual.
Changes Made
scripts/release/prepare.sh
--create-tags
flag)RELEASE.md
updated to include the automated optionUsage
Create Release PR
Create Tags (After PR is merged)
# Step 3: Create and push tags with confirmation bash ./scripts/release/prepare.sh v1.73.0 v2.10.0 --create-tags
Dry Run
# Preview changes without creating PR or tags DRY_RUN=true bash ./scripts/release/prepare.sh v1.73.0 v2.10.0 DRY_RUN=true bash ./scripts/release/prepare.sh v1.73.0 v2.10.0 --create-tags
Features
Implementation Details
Manual Steps (unchanged)
Testing
The script has been tested with:
bash -n
)Closes #7500