feat(metrics): SigV4 HTTP auth support for Prometheus metric backend #7520

SoumyaRaikwar · 2025-09-24T14:58:07Z

This PR enables Jaeger to use AWS Managed Prometheus (AMP) for span-metrics by adding SigV4 HTTP authentication support to the Prometheus metric backend.

Summary of changes

Configuration
- Add jaeger_storage.metric_backends..auth.authenticator to reference an OpenTelemetry HTTP authenticator extension by name.
Extension resolution
- At startup, resolve the named extension from the Collector Host and validate it implements go.opentelemetry.io/collector/extension/extensionauth.HTTPClient.
Prometheus metric backend
- Thread the resolved HTTP authenticator into the Prometheus factory and metricstore.
- Wrap the HTTP RoundTripper used by the Prometheus client with the extension’s RoundTripper (applies SigV4 signing when using sigv4authextension).
Jaeger build
- Include github.com/open-telemetry/opentelemetry-collector-contrib/extension/sigv4authextension in the Jaeger collector build so it can be referenced in config.

Configuration example

extensions:
  sigv4auth:
    region: us-east-1
    service: aps
    # credentials/assume-role configuration per the extension’s documentation

jaeger_storage:
  metric_backends:
    amp:
      prometheus:
        endpoint: https://aps-workspaces.<region>.amazonaws.com/workspaces/<workspace_id>/api/v1
        # tls/connect_timeout/extra_query_parameters as needed
      auth:
        authenticator: sigv4auth

Implementation

The Prometheus metricstore now supports an optional HTTP authenticator:
- If configured, the base RoundTripper (which already supports bearer tokens from file/context) is wrapped by the extension-provided RoundTripper. This is where SigV4 signing is applied for AMP.
The SigV4 extension is included in the collector build to ensure it’s available in host.GetExtensions().

Scope

Limited to the span-metrics (Prometheus) backend.
No changes to trace storages (Cassandra, ES, gRPC, etc.).

Related issue

Fixes [Feature]: Sigv4auth support for backend storage #7468

…ackend - Resolve auth extension by name (extensionauth.HTTPClient) - Wire authenticator through Jaeger storage extension - Wrap Prometheus HTTP RoundTripper with authenticator (e.g., SigV4) This enables using AWS Managed Prometheus with SigV4 auth. Refs: jaegertracing#7468 Signed-off-by: Soumya Raikwar <[email protected]>

Add sigv4authextension to the Jaeger collector build so it can be referenced from jaeger_storage.metric_backends.<name>.auth.authenticator. This completes the wiring to support AWS AMP via SigV4 for span-metrics. Refs: jaegertracing#7468 Signed-off-by: Soumya Raikwar <[email protected]>

SoumyaRaikwar · 2025-09-26T18:42:34Z

@yurishkuro could you please review my pr

cmd/jaeger/internal/extension/jaegerstorage/config.go

SoumyaRaikwar · 2025-09-30T05:31:30Z

@yurishkuro i have documented valid values in code/schema , could you please review my pr again?

codecov · 2025-10-04T18:54:18Z

Codecov Report

❌ Patch coverage is 95.38462% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.50%. Comparing base (d510cf5) to head (57f7a30).

Files with missing lines	Patch %	Lines
...orage/metricstore/prometheus/metricstore/reader.go	82.35%	2 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #7520      +/-   ##
==========================================
+ Coverage   96.49%   96.50%   +0.01%     
==========================================
  Files         385      385              
  Lines       23316    23372      +56     
==========================================
+ Hits        22498    22556      +58     
+ Misses        629      627       -2     
  Partials      189      189

Flag	Coverage Δ
badger_v1	`9.01% <ø> (ø)`
badger_v2	`1.58% <0.00%> (-0.01%)`	⬇️
cassandra-4.x-v1-manual	`11.67% <ø> (ø)`
cassandra-4.x-v2-auto	`1.57% <0.00%> (-0.01%)`	⬇️
cassandra-4.x-v2-manual	`1.57% <0.00%> (-0.01%)`	⬇️
cassandra-5.x-v1-manual	`11.67% <ø> (ø)`
cassandra-5.x-v2-auto	`1.57% <0.00%> (-0.01%)`	⬇️
cassandra-5.x-v2-manual	`1.57% <0.00%> (-0.01%)`	⬇️
clickhouse	`1.52% <0.00%> (-0.01%)`	⬇️
elasticsearch-6.x-v1	`16.56% <ø> (ø)`
elasticsearch-7.x-v1	`16.61% <ø> (ø)`
elasticsearch-8.x-v1	`16.75% <ø> (ø)`
elasticsearch-8.x-v2	`1.58% <0.00%> (-0.01%)`	⬇️
elasticsearch-9.x-v2	`1.58% <0.00%> (-0.01%)`	⬇️
grpc_v1	`10.21% <ø> (ø)`
grpc_v2	`1.58% <0.00%> (-0.01%)`	⬇️
kafka-3.x-v1	`9.66% <ø> (ø)`
kafka-3.x-v2	`1.58% <0.00%> (-0.01%)`	⬇️
memory_v2	`1.58% <0.00%> (-0.01%)`	⬇️
opensearch-1.x-v1	`16.65% <ø> (ø)`
opensearch-2.x-v1	`16.65% <ø> (ø)`
opensearch-2.x-v2	`1.58% <0.00%> (-0.01%)`	⬇️
opensearch-3.x-v2	`1.58% <0.00%> (-0.01%)`	⬇️
query	`1.58% <0.00%> (-0.01%)`	⬇️
tailsampling-processor	`0.43% <0.00%> (-0.01%)`	⬇️
unittests	`95.50% <95.38%> (+0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-10-04T18:57:10Z

Metrics Comparison Summary

Total changes across all snapshots: 106

Detailed changes per snapshot

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 53 metrics
❌ Removed: 0 metrics
🔄 Modified: 0 metrics

🆕 Added Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

### summary_metrics_snapshot_cassandra ## 📊 Metrics Diff Summary

Total Changes: 53

🆕 Added: 53 metrics
❌ Removed: 0 metrics
🔄 Modified: 0 metrics

🆕 Added Metrics

http_server_request_body_size_bytes (18 variants)

View diff sample

+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_request_duration_seconds` (17 variants)

View diff sample

+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

- `http_server_response_body_size_bytes` (18 variants)

View diff sample

+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...

➡️ View full metrics file

yurishkuro · 2025-10-04T19:25:39Z

the build is broken

SoumyaRaikwar · 2025-10-05T05:04:31Z

@yurishkuro Tests added!

Changes:

Added 16 comprehensive tests covering all authentication code paths
Extension authenticator resolution tests (5 tests)
Factory creation with authenticator tests (4 tests)
Reader HTTP RoundTripper wrapping tests (7 tests)
Fixed existing tests for backward compatibility

Coverage Results:

extension.go: 99.4% (was 0%)
factory.go: 100% (was 0%)
reader.go: 95%+ (was 0%)

The build should now pass. could you please re-review ?

SoumyaRaikwar · 2025-10-06T05:29:12Z

@yurishkuro could you please review my pr

cmd/jaeger/internal/extension/jaegerstorage/extension.go

cmd/jaeger/internal/extension/jaegerstorage/config.go

SoumyaRaikwar · 2025-10-10T07:16:51Z

@yurishkuro Fixed both issues:

Removed code duplication - Single factory call instead of if/else
Moved auth to Prometheus config - Follows same pattern as Elasticsearch/Cassandra

Created PrometheusConfiguration struct that wraps promCfg.Configuration with embedded Auth field.

could you please re-review?

internal/storage/metricstore/prometheus/metricstore/reader_test.go

yurishkuro · 2025-10-11T21:53:34Z

this PR includes many unrelated formatting changes (see #7556)

… in config.go Signed-off-by: Soumya Raikwar <[email protected]>

- Add authenticator resolution tests to extension_test.go - Add factory tests for NewFactoryWithConfigAndAuth - Add reader tests for authentication RoundTripper wrapping - Fix existing tests to pass nil authenticator parameter This brings coverage from 0% to 95%+ for new authentication code. Signed-off-by: Soumya Raikwar <[email protected]>

- Add error handling for NewFactoryWithConfigAndAuth - Replace context.Background() with t.Context() in tests - Fix unused receivers and parameters - Use http.StatusOK constant instead of 200 - Use t.TempDir() and WriteString in tests - Format with gofmt Signed-off-by: Soumya Raikwar <[email protected]>

@yurishkuro

…code duplication - Move AuthConfig from MetricBackend to PrometheusConfiguration - Eliminate duplicated factory creation code - Access auth via cfg.Prometheus.Auth instead of cfg.Auth - Update all tests to use new configuration structure Addresses review feedback from @yurishkuro: - Auth config now follows same pattern as other storage backends - No code duplication in factory creation Signed-off-by: Your Name <[email protected]>

Removed empty line additions in test files unrelated to SigV4 auth: - ES rollover test - Remote storage test - Metrics test - Cassandra tests - Elasticsearch tests - UI converter test These were leftover from merge commits and are not part of the SigV4 feature. Signed-off-by: Soumya Raikwar <[email protected]> Signed-off-by: SoumyaRaikwar <[email protected]>

SoumyaRaikwar · 2025-10-13T12:00:36Z

@yurishkuro All review feedback addressed!

Changes made:

Merged NewMetricsReader and NewMetricsReaderWithAuth → single function with optional httpAuth parameter
Merged NewFactoryWithConfig and NewFactoryWithConfigAndAuth → single function
Removed if/else in CreateMetricsReader - now passes httpAuth directly (nil-safe)
Removed 7 duplicate WithAuth test functions
Added table-driven TestNewMetricsReaderWithHTTPAuth test
Inline parameter initialization in tests

All callsites updated. Functions now accept optional httpAuth parameter throughout the codebase.

could you please review again?

Signed-off-by: SoumyaRaikwar <[email protected]>

cmd/jaeger/internal/extension/jaegerstorage/config.go

cmd/jaeger/internal/extension/jaegerstorage/extension.go

@yurishkuro

- Fix indentation of promTelset assignment - Remove duplicate Auth field from MetricBackend - Fix nil comparison for Authenticator string field - Access auth via cfg.Prometheus.Auth instead of cfg.Auth Addresses review feedback from @yurishkuro Signed-off-by: SoumyaRaikwar <[email protected]>

- Add nolint comment for getAuthenticator receiver - Update all tests to use t.Context() - Fix indentation and formatting - All jaegerstorage tests passing All changes tested and verified locally. Signed-off-by: SoumyaRaikwar <[email protected]>

internal/storage/metricstore/prometheus/metricstore/reader.go

Signed-off-by: Soumya Raikwar <[email protected]>

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: Soumya Raikwar <[email protected]>

SoumyaRaikwar · 2025-10-13T21:03:34Z

@yurishkuro, I'm seeing a revive warning about unused receiver in getAuthenticator. I've added a //nolint:revive comment since the receiver isn't used in the function body. Is this the preferred approach, or would you prefer converting it to a standalone function?

SoumyaRaikwar · 2025-10-13T21:04:03Z

@yurishkuro Fixed both issues!

Changes:

Fixed indentation of promTelset := telset
Removed duplicate Auth field from MetricBackend
Auth now accessed via cfg.Prometheus.Auth only

could you please review again ?

yurishkuro · 2025-10-13T23:08:30Z

cmd/jaeger/internal/extension/jaegerstorage/extension.go

 	return mf, ok
 }
+
+//nolint:revive // receiver not used but kept as method for consistency // getAuthenticator retrieves an HTTP authenticator extension from the host by name


what's with the many slashes ?

yurishkuro · 2025-10-13T23:11:07Z

cmd/jaeger/internal/extension/jaegerstorage/extension_test.go

+	require.NotNil(t, factory)
+
+	t.Cleanup(func() {
+		require.NoError(t, ext.(extension.Extension).Shutdown(t.Context()))


t.Context() is cancelled during Cleanup

yurishkuro · 2025-10-13T23:12:03Z

internal/storage/metricstore/prometheus/metricstore/reader.go

+	return createPromClientWithAuth(cfg, nil)
+}
+
+func createPromClientWithAuth(cfg config.Configuration, httpAuth extensionauth.HTTPClient) (api.Client, error) {


why new function? they are both private, only one form is needed

internal/storage/metricstore/prometheus/metricstore/reader.go

yurishkuro · 2025-10-13T23:14:04Z

internal/storage/metricstore/prometheus/metricstore/reader_test.go

+		{
+			name:         "with HTTP authenticator",
+			httpAuth:     &mockHTTPAuthenticator{},
+			wantAuthUsed: true,


redundant flag, can use httpAuth != nil

yurishkuro · 2025-10-13T23:15:14Z

internal/storage/metricstore/prometheus/factory_test.go

+	require.NotNil(t, factory)
+
+	// Verify the factory can create a metrics reader
+	reader, err := factory.CreateMetricsReader()


this doesn't test that auth-r was used by the factory

Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Soumya Raikwar <[email protected]>

graphite-app · 2025-10-14T04:57:13Z

internal/storage/metricstore/prometheus/metricstore/reader.go

+	if httpAuth == nil {
+		return base, nil
+	}
+	return httpAuth.RoundTripper(base)


The call to httpAuth.RoundTripper() returns an error that should be handled. Consider updating the code to check for errors:

authenticatedRT, rtErr := httpAuth.RoundTripper(base) if rtErr != nil { return nil, rtErr } return authenticatedRT, nil

This ensures any authentication setup failures are properly propagated to the caller rather than silently ignored.

Suggested change

return httpAuth.RoundTripper(base)

authenticatedRT, rtErr := httpAuth.RoundTripper(base)

if rtErr != nil {

return nil, rtErr

}

return authenticatedRT, nil

Spotted by Graphite Agent

Is this helpful? React 👍 or 👎 to let us know.

- Fix comment formatting in extension.go to follow Go conventions - Replace t.Context() with context.Background() in test cleanup functions - Remove redundant wantAuthUsed flag from reader_test.go - Add authenticator verification in factory_test.go - Use http.StatusOK constant instead of hardcoded 200 Signed-off-by: SoumyaRaikwar <[email protected]>

SoumyaRaikwar · 2025-10-14T09:12:35Z

@yurishkuro All feedback addressed!

Fixed:

Comment formatting in extension.go - now starts with function name
Replaced t.Context() with context.Background() in cleanup functions (4 locations)
Confirmed no duplicate createPromClient function
Removed redundant wantAuthUsed flag from reader_test.go
Added authenticator verification in factory_test.go with called assertion

Ready for re-review!

SoumyaRaikwar added 2 commits September 24, 2025 20:11

SoumyaRaikwar requested a review from a team as a code owner September 24, 2025 14:58

SoumyaRaikwar requested a review from joe-elliott September 24, 2025 14:58

dosubot bot added area/storage enhancement labels Sep 24, 2025

yurishkuro reviewed Sep 26, 2025

View reviewed changes

cmd/jaeger/internal/extension/jaegerstorage/config.go Outdated Show resolved Hide resolved

SoumyaRaikwar requested a review from yurishkuro September 27, 2025 10:46

yurishkuro added the changelog:bugfix-or-minor-feature label Oct 4, 2025

SoumyaRaikwar force-pushed the feature/sigv4auth-storage-backend branch from 57f7a30 to 2b736d7 Compare October 6, 2025 05:27

yurishkuro reviewed Oct 7, 2025

View reviewed changes

cmd/jaeger/internal/extension/jaegerstorage/extension.go Outdated Show resolved Hide resolved

yurishkuro reviewed Oct 7, 2025

View reviewed changes

cmd/jaeger/internal/extension/jaegerstorage/config.go Outdated Show resolved Hide resolved

graphite-app bot reviewed Oct 10, 2025

View reviewed changes

internal/storage/metricstore/prometheus/metricstore/reader_test.go Outdated Show resolved Hide resolved

SoumyaRaikwar requested a review from yurishkuro October 10, 2025 07:17

SoumyaRaikwar and others added 4 commits October 12, 2025 11:56

docs(metrics): document valid values for metric backend authenticator…

8134630

… in config.go Signed-off-by: Soumya Raikwar <[email protected]>

SoumyaRaikwar force-pushed the feature/sigv4auth-storage-backend branch from a43ca3c to 7f20021 Compare October 12, 2025 06:29

SoumyaRaikwar force-pushed the feature/sigv4auth-storage-backend branch from 7f20021 to a7bd21b Compare October 12, 2025 06:33

chore: update dependencies for SigV4 and OTEL integration

3dee417

Signed-off-by: SoumyaRaikwar <[email protected]>

SoumyaRaikwar requested a review from yurishkuro October 13, 2025 12:44

yurishkuro reviewed Oct 13, 2025

View reviewed changes

cmd/jaeger/internal/extension/jaegerstorage/config.go Outdated Show resolved Hide resolved

yurishkuro reviewed Oct 13, 2025

View reviewed changes

cmd/jaeger/internal/extension/jaegerstorage/extension.go Outdated Show resolved Hide resolved

SoumyaRaikwar added 2 commits October 14, 2025 01:30

SoumyaRaikwar force-pushed the feature/sigv4auth-storage-backend branch from c7d722c to c066f58 Compare October 13, 2025 20:53

graphite-app bot reviewed Oct 13, 2025

View reviewed changes

internal/storage/metricstore/prometheus/metricstore/reader.go Show resolved Hide resolved

SoumyaRaikwar and others added 2 commits October 14, 2025 02:29

Merge branch 'main' into feature/sigv4auth-storage-backend

06d842d

Signed-off-by: Soumya Raikwar <[email protected]>

Update internal/storage/metricstore/prometheus/metricstore/reader.go

cb294d3

Co-authored-by: graphite-app[bot] <96075541+graphite-app[bot]@users.noreply.github.com> Signed-off-by: Soumya Raikwar <[email protected]>

SoumyaRaikwar requested a review from yurishkuro October 13, 2025 21:05

yurishkuro reviewed Oct 13, 2025

View reviewed changes

internal/storage/metricstore/prometheus/metricstore/reader.go Outdated Show resolved Hide resolved

yurishkuro reviewed Oct 13, 2025

View reviewed changes

internal/storage/metricstore/prometheus/metricstore/reader.go Outdated Show resolved Hide resolved

yurishkuro reviewed Oct 13, 2025

View reviewed changes

SoumyaRaikwar and others added 2 commits October 14, 2025 10:23

Update internal/storage/metricstore/prometheus/metricstore/reader.go

c8d3ab8

Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Soumya Raikwar <[email protected]>

Update internal/storage/metricstore/prometheus/metricstore/reader.go

357a9ec

Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: Soumya Raikwar <[email protected]>

graphite-app bot reviewed Oct 14, 2025

View reviewed changes

SoumyaRaikwar and others added 2 commits October 14, 2025 14:10

Merge branch 'main' into feature/sigv4auth-storage-backend

a800f50

SoumyaRaikwar requested a review from yurishkuro October 14, 2025 09:12

SoumyaRaikwar added 2 commits October 14, 2025 18:28

Merge branch 'main' into feature/sigv4auth-storage-backend

72f9c2e

Merge branch 'main' into feature/sigv4auth-storage-backend

4ac099b

-	return httpAuth.RoundTripper(base)
+	authenticatedRT, rtErr := httpAuth.RoundTripper(base)
+	if rtErr != nil {
+		return nil, rtErr
+	}
+	return authenticatedRT, nil

feat(metrics): SigV4 HTTP auth support for Prometheus metric backend #7520

Are you sure you want to change the base?

feat(metrics): SigV4 HTTP auth support for Prometheus metric backend #7520

Uh oh!

Conversation

SoumyaRaikwar commented Sep 24, 2025

Uh oh!

SoumyaRaikwar commented Sep 26, 2025

Uh oh!

Uh oh!

SoumyaRaikwar commented Sep 30, 2025

Uh oh!

codecov bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Oct 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Metrics Comparison Summary

summary_metrics_snapshot_cassandra

📊 Metrics Diff Summary

🆕 Added Metrics

🆕 Added Metrics

Uh oh!

yurishkuro commented Oct 4, 2025

Uh oh!

SoumyaRaikwar commented Oct 5, 2025

Uh oh!

SoumyaRaikwar commented Oct 6, 2025

Uh oh!

Uh oh!

Uh oh!

SoumyaRaikwar commented Oct 10, 2025

Uh oh!

Uh oh!

yurishkuro commented Oct 11, 2025

Uh oh!

SoumyaRaikwar commented Oct 13, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

SoumyaRaikwar commented Oct 13, 2025

Uh oh!

SoumyaRaikwar commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yurishkuro Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

yurishkuro Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

yurishkuro Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

yurishkuro Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

yurishkuro Oct 13, 2025

Choose a reason for hiding this comment

Uh oh!

graphite-app bot Oct 14, 2025

Choose a reason for hiding this comment

Uh oh!

SoumyaRaikwar commented Oct 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Oct 4, 2025 •

edited

Loading

github-actions bot commented Oct 4, 2025 •

edited

Loading

SoumyaRaikwar commented Oct 13, 2025 •

edited

Loading