jtracer removed from Jaeger-V2 jaeger-query #7542
Conversation
Signed-off-by: anmol7344 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7542 +/- ##
==========================================
+ Coverage 96.49% 96.53% +0.04%
==========================================
Files 385 385
Lines 23316 23303 -13
==========================================
- Hits 22498 22496 -2
+ Misses 629 621 -8
+ Partials 189 186 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: anmol7344 <[email protected]>
Signed-off-by: anmol7344 <[email protected]>
| } | ||
|
|
||
| func newServer(config *Config, otel component.TelemetrySettings) *server { | ||
| func newServer(config *Config, telemetry component.TelemetrySettings) *server { |
There was a problem hiding this comment.
yes I noticed it in V1 codebase my bad.
Metrics Comparison SummaryTotal changes across all snapshots: 53 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 53
🆕 Added Metrics
View diff sample+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...View diff sample+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
...View diff sample+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.62.0",server_address="localhost",server_port="13133",url_scheme="http"}
... |
|
I want to clarify — is it because JaegerQuery currently does not emit any spans? My goal with this PR is to migrate to the OTEL collector tracer from jtracer, and I want to make sure I understand what would make this PR functional and non-cosmetic. |
| } | ||
| }(ctx) | ||
| // Getting Tracer from OTEL | ||
| tp = otel.GetTracerProvider() |
There was a problem hiding this comment.
you are not getting the tracer configured by OTEL collector, you're getting a global tracer, which may or may not be the same.
There was a problem hiding this comment.
you mean i should define and configure the otel tracer here itself?
something like this?
res := resource.NewWithAttributes(
semconv.SchemaURL,
semconv.ServiceNameKey.String("jaeger-query"),
)
exporter, err := otlptracegrpc.New(context.Background(),
otlptracegrpc.WithEndpoint(endpoint),
otlptracegrpc.WithInsecure(),
)
if err != nil {
return fmt.Errorf("failed to create OTLP trace exporter", err)
}
tp := sdktrace.NewTracerProvider(
sdktrace.WithBatcher(exporter),
sdktrace.WithResource(res),
)
otel.SetTracerProvider(tp)
There was a problem hiding this comment.
OTEL collector initializes all telemetry factories. The point of the ticket was that we shouldn't duplicate that initialization (which allows fewer customizations) and instead rely on the factories created by OTEL Collector framework.
There was a problem hiding this comment.
even i thought this (as it would just defy the purpose of the issue) i just wanted to clarify by asking as I got confused.
There was a problem hiding this comment.
I was looking at the Collector code and found this in service/service.go:
https://github.com/open-telemetry/opentelemetry-collector/blob/3b5555471b93052c4fbe4ef412d974a999d1b27f/service/service.go#L169
It seems like Service.New() initializes the tracerProvider via the telemetry factory.
For this issue, should we use this TracerProvider in Jaeger Query, or is there a different factory we should be referencing?
There was a problem hiding this comment.
We are already getting it via component.TelemetrySettings, so we should be using that's in there instead of creating our own. But we need to verify that we're getting the same traces in the end.
Signed-off-by: anmol7344 <[email protected]>
| tp = jtracer.NoOp().OTEL | ||
| tp = noop.NewTracerProvider() | ||
|
|
||
| if s.config.EnableTracing { |
There was a problem hiding this comment.
Do we still need this setting? Can it not be controlled from telemetry section of otel config?
There was a problem hiding this comment.
Should it be removed from QueryOptions struct as well?
I believe that Jaeger Query does not emit spans with the current setup and if so should it be made to emit spans for testing purpose? |
it always has, if you reload jaeger UI a few times you should see |
Oh, I see! I was always running the Jaeger v1 all-in-one Docker image, so I hadn’t really never noticed the dropdown changes. |
|
I tried testing Jaeger v2 locally by building the binary from |
|
it makes no difference is you run a binary or docker image. Jaeger accepts |
Oh sorry! Actually I misunderstood the error. I built Jaeger v2 from and is there a make/generate step for embedding the UI into the binary when building locally? |
|
|
|
Hi @yurishkuro I’ve tried WSL and other options, but none worked in my environment. I understand from the scripts that Jaeger development is Linux-first. Given these constraints, could you advise the recommended workflow for contributors on Windows? Would it be acceptable to submit the backend change for review/testing on a Linux environment, or is there an alternative approach for testing? Thank you for your guidance and time! |
|
post the errors you're getting if you're asking for help. did you initialize the ui submodule? the build-ui normally works by downloading the bundle from the release, you don't actually need to build anything. |
Ah! sorry for not posting the steps I performed earlier and thanks for the hint! I realized I hadn’t initialized the UI submodule, and after doing that, the |
I tested this pr and attaching the screenshots of the changes.After changes from this pr
Even after refreshing several times I did not see Jaeger service in the dropdown. 
Before changes from this pr
Jaeger service was always showing in the dropdown and showing traces even before sending traces from HotROD demo. |
|
It seems this change currently breaks span collection for Jaeger service. Steps to reproduce :-
With this setup, I wasn't able to see spans being collected. |
|
in $ JAEGER_VERSION=2.11.0 HOTROD_VERSION=1.74.0 docker compose up
|
|
@yurishkuro |
2 participants
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test