-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[refactor]: use strings.Builder to improve performance #7630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@claudecodering Is there a linter that would enforce this change? |
I wrote one locally, but it only performs detection — most of the changes still require manual intervention. |
@claudecodering Looks like |
…cat-loop Signed-off-by: claudecodering <[email protected]>
Of course! I’d love to do that. |
|
Please review again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7630 +/- ##
==========================================
- Coverage 96.59% 96.53% -0.06%
==========================================
Files 384 384
Lines 19404 19476 +72
==========================================
+ Hits 18744 18802 +58
- Misses 477 489 +12
- Partials 183 185 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@claudecodering The CI is failing. This PR needs to be opened from a branch on your fork instead of main. |
Which problem is this PR solving?
Description of the changes
strings.Builder has fewer memory allocations and better performance.
More info: golang/go#75190
How was this change tested?
No need.
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test