tracegen: add capability to marshal spans to file #7691
+86
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
When you have text |
yurishkuro
reviewed
Dec 4, 2025
cmd/tracegen/main.go
Outdated
| if fileWriter != nil { | ||
| return stdouttrace.New( | ||
| stdouttrace.WithWriter(fileWriter), | ||
| stdouttrace.WithPrettyPrint(), |
Member
There was a problem hiding this comment.
why do you need pretty-print for what is meant to be a machine-readable format?
Author
There was a problem hiding this comment.
Oh sorry, I did it for debugging, but you're right, production doesn't need it
yurishkuro
reviewed
Dec 4, 2025
Samriddha9619
force-pushed
the
feature/tracegen-file-export
branch
from
9dcee2c to
bbb5126
Compare
yurishkuro
reviewed
Dec 5, 2025
internal/tracegen/config.go
Outdated
| fs.StringVar(&c.Service, "service", "tracegen", "Service name prefix to use") | ||
| fs.IntVar(&c.Services, "services", 1, "Number of unique suffixes to add to service name when generating traces, e.g. tracegen-01 (but only one service per trace)") | ||
| fs.StringVar(&c.TraceExporter, "trace-exporter", "otlp-http", "Trace exporter (otlp/otlp-http|otlp-grpc|stdout). Exporters can be additionally configured via environment variables, see https://github.com/jaegertracing/jaeger/blob/main/cmd/tracegen/README.md") | ||
| fs.StringVar(&c.ExportToFile, "export-to-file", "", "Filename to write generated spans to (in JSON format) instead of sending to a collector") |
Member
There was a problem hiding this comment.
I was just thinking - adding this new option creates an ambiguity, which one takes precedence, this one or trace-exporter. We can keep it to a single flag if we allow file:{filename} syntax.
Btw the README incorrectly says the option name is -exporter, can you fix it in the same PR?
Signed-off-by: Samriddha9619 <[email protected]>
Samriddha9619
force-pushed
the
feature/tracegen-file-export
branch
from
872ebd9 to
8e7c11f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
-marshal-to-filetointernal/tracegen/config.go.cmd/tracegen/main.goto intercept the exporter creation logic.stdoutexporter is initialized with a customos.Filewriter instead of the defaultos.Stdout.How was this change tested?
./tracegen -marshal-to-file=test.json -traces=1test.jsoncontains valid, clean JSON span data with no log corruption.golangci-linton modified packages (passed).go test ./internal/tracegen/...(passed).Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test