-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Eliminate v1 binary references and sunset deprecated components #7695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…, ingester) Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
Co-authored-by: yurishkuro <[email protected]>
|
@copilot in .github/workflows/ci-release.yml I see you left some commands that start with BRANCH=$(make echo-v2). This is no longer necessary since the earlier step now sets this env var by default to v2 version |
Co-authored-by: yurishkuro <[email protected]>
Fixed in d67157c - removed the redundant BRANCH assignment since it's already set as an environment variable in the earlier step. |
|
@copilot in scripts/makefiles/BuildBinaries.mk you did not remove targets like build-query, even though you removed calls to those targets |
…, ingester) Co-authored-by: yurishkuro <[email protected]>
|
@copilot in scripts/build/package-deploy.sh you removed function stage-platform-files-v1 but it was also handling the hotrod binary which must remain but move to v2 |
The hotrod binary is already included in the stage-platform-files function (line 46 in package-deploy.sh). When I consolidated the v1 and v2 functions in commit b30f301, I made sure to include hotrod in the merged function alongside the jaeger binary. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7695 +/- ##
==========================================
- Coverage 96.55% 96.54% -0.02%
==========================================
Files 384 384
Lines 19511 19511
==========================================
- Hits 18839 18837 -2
- Misses 487 489 +2
Partials 185 185
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@copilot in scripts/makefiles/BuildInfo.mk can we not eliminate BUILD_INFO_V2 and only keep BUILD_INFO ? |
Co-authored-by: yurishkuro <[email protected]>
Fixed in 34234a7 - consolidated all image build calls into a |
|
@copilot in scripts/makefiles/BuildInfo.mk you are calling |
Makefile
Outdated
| echo-v1: | ||
| @echo "$(GIT_CLOSEST_TAG_V1)" | ||
|
|
||
| .PHONY: echo-v2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should be renamed echo-version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in d93bd06 - renamed echo-v2 to echo-version in Makefile and updated all references across workflows and scripts.
…ve deprecated binaries Co-authored-by: yurishkuro <[email protected]>
Fixed in e1783d1 - removed the v2 argument from compute-version.sh calls (script now defaults to v2), updated Windows.mk to use v2 and removed deprecated binaries (collector, query, ingester, all-in-one). |
|
@copilot make scripts/utils/compute-version.sh always work for v2, no need for v1 logic |
…upport v2 Co-authored-by: yurishkuro <[email protected]>
|
@copilot The following workflows are failing CIT Hotrod / hotrod (docker, v1) (pull_request) which is expected since they rely on v1 artifacts. They should be removed. |
Co-authored-by: yurishkuro <[email protected]>
Fixed in 1797f36 - removed v1 test jobs from both workflows. In ci-docker-hotrod.yml, removed v1 from the jaeger-version matrix. In ci-e2e-spm.yml, removed the v1 test mode that used the all-in-one binary. |
|
@copilot scripts/build/build-upload-docker-images.sh:88 the utilities were previously built without |
Co-authored-by: yurishkuro <[email protected]>
Fixed in 95a2921 - updated the build_image helper function to only add the |
| BRANCH=$(make echo-version) | ||
| echo Validate that the latest tag ${BRANCH} is in semver format | ||
| echo ${BRANCH} | grep -E '^v[0-9]+.[0-9]+.[0-9]+$' | ||
| echo ${BRANCH} | grep -E '^v[0-9]+.[0-9]+.[0-9]+(-rc[0-9]+)?$' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The regex pattern has unescaped dots which will match any character instead of literal dots. This will incorrectly validate malformed version strings like v2a0b0 as valid semver.
Fix:
echo ${BRANCH} | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)?$'The dots need to be escaped as \. to match literal dot characters in version strings.
| echo ${BRANCH} | grep -E '^v[0-9]+.[0-9]+.[0-9]+(-rc[0-9]+)?$' | |
| echo ${BRANCH} | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+(-rc[0-9]+)?$' |
Spotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
Metrics Comparison SummaryTotal changes across all snapshots: 53 Detailed changes per snapshotsummary_metrics_snapshot_cassandra📊 Metrics Diff SummaryTotal Changes: 53
🆕 Added Metrics
View diff sample+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...View diff sample+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.005",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.01",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.025",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.05",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.075",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_request_duration_seconds{http_request_method="GET",http_response_status_code="503",le="0.1",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
...View diff sample+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="+Inf",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="0",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="100",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="1000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="10000",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
+http_server_response_body_size_bytes{http_request_method="GET",http_response_status_code="503",le="25",network_protocol_name="http",network_protocol_version="1.1",otel_scope_name="go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp",otel_scope_schema_url="",otel_scope_version="0.63.0",server_address="localhost",server_port="13133",url_scheme="http"}
... |
Migration Plan: Remove v1 references and sunset deprecated binaries
Summary
Successfully removed all v1 references from the build and release process. The following deprecated v1 binaries are no longer built or released:
The following binaries continue to be released as v2:
All version references now point to v2, and the packaging and Docker image builds have been updated accordingly.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.