-
Notifications
You must be signed in to change notification settings - Fork 75
ci(docker): Publish versioned, multiarch releases #153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(docker): Publish versioned, multiarch releases #153
Conversation
Signed-off-by: Kleo Davidson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix!
.github/workflows/publish-image.yaml
Outdated
push: | ||
branches: [ main ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should remove this trigger, otherwise latest
is just random, not an official release
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm inclined to agree! I just retained it to preserve the existing behavior. I'll remove it in a followup commit shortly.
Signed-off-by: Kleo Davidson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@davidsow https://github.com/jaegertracing/spark-dependencies/actions/runs/13777743816/job/38530254487
|
Interesting - I will run this down and determine a fix. |
you probably need buildx, see this example https://github.com/jaegertracing/docker-protobuf/blob/20742e70e824967ad7abd13e693238fc612bbfb2/.github/workflows/build-and-publish.yml#L24 |
That does seem to be the problem! I've opened #154 to rectify the build failure |
Which problem is this PR solving?
This change to the publication process solves two outstanding issues:
As these two issues have been outstanding for some time, I opted not to create a new issue for these changes. I am happy to rectify that if need be.
Description of the changes
Versioned Publication
publish-image.yml
GitHub workflow has been retooled to allow for tagged releases.release
: Creating a release on the GitHub repo will publish an image with a matching tagworkflow-dispatch
: The workflow can be run manually with an arbitrary tag string.latest
tag, preserving the current behavior.This change presupposes no particular release / versioning strategy - it merely provides the foundation
for adopting one. At present, any deployment of this software is vulnerable to a breaking release of the
code overriding the
latest
tag with no warning. This change provides the ability to create a long-livedimage publication that can be considered stable.
ARM64
publish-image.yml
workflow now publishes bothlinux/amd64
andlinux/arm64
images.Tests
testcontainers
has been updated tov1.20.6
to fix a bug preventing tests passing on (at least) Apple M1 hardware.How was this change tested?
README.md
linux/arm64
variant of the image builds and tests well on Apple M1 hardware.Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test