-
Notifications
You must be signed in to change notification settings - Fork 101
Use Duration instead of raw seconds and millis #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
@jaemk can you approve the workflow? I ran most of the tests locally but got connection errors with the redis tests. |
@jaemk Thanks for approving the workflow! I have no idea what caused it to fail. It didn't get to the part where it runs the tests. |
Looks like the workflow definition needs to be updated.
|
Is it as simple as updating the version to 3 or 4? or is that going to break other things? |
@jaemk Looks like I need another approval for the workflow. |
Those test errors are strange and I'm not sure why I didn't see them in my run.... but I've pushed some updates that hopefully resolve the failures. Edit: Apparently I had to run |
@jaemk I am not understanding the current check failure... I think it's complaining that the readme was changed? But I thought I read in the contributing guidelines to update the readme. |
closes #74