Skip to content

Use Duration instead of raw seconds and millis #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hcldan
Copy link

@hcldan hcldan commented Apr 23, 2025

closes #74

@hcldan
Copy link
Author

hcldan commented Apr 24, 2025

@jaemk can you approve the workflow?

I ran most of the tests locally but got connection errors with the redis tests.
I'm hoping the ci is configured properly.

@hcldan
Copy link
Author

hcldan commented Apr 30, 2025

@jaemk Thanks for approving the workflow! I have no idea what caused it to fail. It didn't get to the part where it runs the tests.

@jaemk
Copy link
Owner

jaemk commented Apr 30, 2025

Looks like the workflow definition needs to be updated.

Your workflow is using a version of actions/cache that is scheduled for deprecation, actions/cache@v2. Please update your workflow to use either v3 or v4 of actions/cache to avoid interruptions. Learn more: https://github.blog/changelog/2024-12-05-notice-of-upcoming-releases-and-breaking-changes-for-github-actions/#actions-cache-v1-v2-and-actions-toolkit-cache-package-closing-down

@hcldan
Copy link
Author

hcldan commented Apr 30, 2025

Is it as simple as updating the version to 3 or 4? or is that going to break other things?
Edit: according to the migration guide it is fully backward compatible.

@hcldan
Copy link
Author

hcldan commented Apr 30, 2025

@jaemk Looks like I need another approval for the workflow.

@hcldan
Copy link
Author

hcldan commented Apr 30, 2025

Those test errors are strange and I'm not sure why I didn't see them in my run.... but I've pushed some updates that hopefully resolve the failures.

Edit: Apparently I had to run cargo test --doc for some of these. My latest commit should address what's left.

@hcldan
Copy link
Author

hcldan commented May 1, 2025

@jaemk I am not understanding the current check failure...

I think it's complaining that the readme was changed? But I thought I read in the contributing guidelines to update the readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimedCache should use Duration rather than u64 in the API
2 participants