fix: reqwest TLS backend #161
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the rustls TLS backend from reqwest is always included and used even when the `rustls` feature is _not_ enabled, via the `use_rustls_tls` function call. This is not only unexpected behaviour but also increases the size of application binaries since both the default (native_tls) and rustls backends are included. When _only_ rustls is needed, use the `rustls` feature _and_ disable the default features.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the rustls TLS backend from reqwest is always included and used even when the
rustlsfeature is not enabled, via theuse_rustls_tlsfunction call.This is not only unexpected behaviour but also increases the size of application binaries since both the default (native_tls) and rustls backends are included.
When only rustls is needed, use the
rustlsfeature and disable the default features.