Skip to content

Conversation

@manovotn
Copy link
Contributor

Another set of changes needed for the release under new coordinates.

<include>**/*.java</include>
</includes>
<!-- This file gets included in the porting package dependencies over from Weld codebase and violates the check -->
<excludes>**/WildFly8EEResourceManager.java</excludes>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of the files that are included as part of the porting package we generate.
Its contents seem to be taken from Weld's code and among those files is this one offending file that doesn't have any license.

I don't think we should check either of these files but rat plugin didn't seem to accept any expression I tried so I ended up excluding just this particular file which works 🤷

@Ladicek
Copy link
Contributor

Ladicek commented Nov 27, 2025

LGTM, although I don't quite understand why we include Weld/WildFly-specific code here. Any explanation?

@manovotn
Copy link
Contributor Author

manovotn commented Nov 27, 2025

LGTM, although I don't quite understand why we include Weld/WildFly-specific code here. Any explanation?

I don't remember why it was done so but Weld parts are used a reference example of how you run the TCKs so I suppose the TCK distribution comes with those so that you can try it locally.
There are scattered notions of it in the TCK docs, such as:

Frankly, I suppose much of this information is going to reference old artifacts or be plain out of date (like using WFLY 22 :)).

@manovotn manovotn merged commit 3407d7f into jakartaee:main Nov 27, 2025
4 checks passed
@manovotn manovotn deleted the anotherCoordinatesFix branch November 27, 2025 11:10
@Ladicek
Copy link
Contributor

Ladicek commented Nov 27, 2025

It's probably just me, but I would get rid of all that. We can just add, to the TCK documentation, some links to where the TCK runner is configured, for example in Weld and in WildFly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants