Skip to content

Fix jakartaee/persistence#713, TCK should not try to lookup by time value with fractional seconds #2184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

beikov
Copy link
Contributor

@beikov beikov commented Apr 11, 2025

@arjantijms
Copy link
Contributor

Something to remember when fixing Persistence tests like these; this is the fork. We also have the original that we intend to transfer to Gavin and team. See jakartaee/persistence#702

Is this fix also needed in the original?

@scottmarlow
Copy link
Contributor

Something to remember when fixing Persistence tests like these; this is the fork. We also have the original that we intend to transfer to Gavin and team. See jakartaee/persistence#702

Is this fix also needed in the original?

I think this pull request and other ones for the persistence-outside-container tests should be made to the Persistence Spec repo after jakartaee/persistence#715 is merged (either as a service 3.2 release change or for 4.0).

@scottmarlow
Copy link
Contributor

Something to remember when fixing Persistence tests like these; this is the fork. We also have the original that we intend to transfer to Gavin and team. See jakartaee/persistence#702
Is this fix also needed in the original?

I think this pull request and other ones for the persistence-outside-container tests should be made to the Persistence Spec repo after jakartaee/persistence#715 is merged (either as a service 3.2 release change or for 4.0).

Although we can continue to make Persistence changes to the tcks/apis/persistence/persistence-inside-container

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants