Skip to content

Conversation

@mkarg
Copy link
Contributor

@mkarg mkarg commented Dec 21, 2024

This PR removes the support for Security Manager.

closes #1262

Requesting fast-track according to our Committer Conventions, as this PR is a non-API, non-spec, non-javadoc change.

@mkarg mkarg added this to the 5.0 milestone Dec 21, 2024
@mkarg mkarg self-assigned this Dec 21, 2024
@mkarg mkarg requested a review from jansupol December 22, 2024 09:21
@jansupol jansupol changed the title Remove Service Manager Remove Security Manager Dec 22, 2024
@jansupol
Copy link
Contributor

Hm...the commit will be forever titled Remove Service Manager instead of Security Manager in the git history....

@mkarg
Copy link
Contributor Author

mkarg commented Dec 22, 2024

Hm...the commit will be forever titled Remove Service Manager instead of Security Manager in the git history....

Good catch, and thank you for changing the typo, but actually it will not show up in git history anyways: The commit itself does not have the typo, and when using "Rebase and merge" in Github, the title of the PR will not show up in the git history. 🙂

@jansupol
Copy link
Contributor

You are right, sorry, I have not checked the commit message

Copy link
Contributor

@jansupol jansupol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for 5.0

@mkarg mkarg requested a review from a team December 23, 2024 12:38
@mkarg mkarg merged commit 8cc8619 into jakartaee:release-5.0 Jan 3, 2025
1 check passed
@mkarg mkarg deleted the remove-service-manager branch January 3, 2025 17:47
@spericas spericas added the EE12 label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: In progress

Development

Successfully merging this pull request may close these issues.

3 participants